refactor: add gsl::not_null annotation for cached_sml and CalcCbTxMerkleRootMNList

Author: knst

src/evo/simplifiedmns.cpp

@@ -96,7 +96,7 @@ bool CSimplifiedMNList::operator==(const CSimplifiedMNList& rhs) const
             );
 }
 
-bool CalcCbTxMerkleRootMNList(uint256& merkleRootRet, std::shared_ptr<const CSimplifiedMNList> sml,
+bool CalcCbTxMerkleRootMNList(uint256& merkleRootRet, gsl::not_null<std::shared_ptr<const CSimplifiedMNList>> sml,
                               BlockValidationState& state)
 {
     try {
@@ -105,7 +105,7 @@ bool CalcCbTxMerkleRootMNList(uint256& merkleRootRet, std::shared_ptr<const CSim
         int64_t nTime1 = GetTimeMicros();
 
         static Mutex cached_mutex;
-        static std::shared_ptr<const CSimplifiedMNList> cached_sml GUARDED_BY(cached_mutex){
+        static gsl::not_null<std::shared_ptr<const CSimplifiedMNList>> cached_sml GUARDED_BY(cached_mutex){
             std::make_shared<const CSimplifiedMNList>()};
         static uint256 merkleRootCached GUARDED_BY(cached_mutex);
         static bool mutatedCached GUARDED_BY(cached_mutex){false};

src/evo/simplifiedmns.h

@@ -9,6 +9,7 @@
 #include <evo/dmn_types.h>
 #include <evo/netinfo.h>
 #include <evo/providertx.h>
+#include <gsl/pointers.h>
 #include <merkleblock.h>
 #include <netaddress.h>
 #include <pubkey.h>
@@ -107,7 +108,7 @@ class CSimplifiedMNList
     bool operator==(const CSimplifiedMNList& rhs) const;
 };
 
-bool CalcCbTxMerkleRootMNList(uint256& merkleRootRet, std::shared_ptr<const CSimplifiedMNList> sml,
+bool CalcCbTxMerkleRootMNList(uint256& merkleRootRet, gsl::not_null<std::shared_ptr<const CSimplifiedMNList>> sml,
                               BlockValidationState& state);
 
 #endif // BITCOIN_EVO_SIMPLIFIEDMNS_H