Fix LLMQ signing integration tests (#2640)

* Fix cleanup of old recovered sigs

When iterating the db, we should also include entries that match exactly
the end time.

* Fix key not found error

* Raise AssertionError in case wait_for_quorum_phase/wait_for_quorum_commitment time out

Author: codablock

qa/rpc-tests/test_framework/test_framework.py

@@ -408,21 +408,23 @@ def wait_for_quorum_phase(self, phase, check_received_messages, check_received_m
                         all_ok = False
                         break
             if all_ok:
-                break
+                return
             sleep(0.1)
+        raise AssertionError("wait_for_quorum_phase timed out")
 
     def wait_for_quorum_commitment(self, timeout = 5):
         t = time()
         while time() - t < timeout:
             all_ok = True
             for node in self.nodes:
                 s = node.quorum("dkgstatus")["session"]["llmq_10"]
-                if not s["receivedFinalCommitment"]:
+                if "receivedFinalCommitment" not in s or not s["receivedFinalCommitment"]:
                     all_ok = False
                     break
             if all_ok:
-                break
+                return
             sleep(0.1)
+        raise AssertionError("wait_for_quorum_commitment timed out")
 
     def mine_quorum(self, expected_valid_count=10):
         quorums = self.nodes[0].quorum("list")

src/llmq/quorums_signing.cpp

@@ -119,8 +119,9 @@ void CRecoveredSigsDb::CleanupOldRecoveredSigs(int64_t maxAge)
 {
     std::unique_ptr<CDBIterator> pcursor(db.NewIterator());
 
+    static const uint256 maxUint256 = uint256S("ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff");
     auto start = std::make_tuple('t', (uint32_t)0, (uint8_t)0, uint256());
-    auto end = std::make_tuple('t', (uint32_t)(GetAdjustedTime() - maxAge), (uint8_t)0, uint256());
+    auto end = std::make_tuple('t', (uint32_t)(GetAdjustedTime() - maxAge), (uint8_t)255, maxUint256);
     pcursor->Seek(start);
 
     std::vector<std::pair<Consensus::LLMQType, uint256>> toDelete;