Skip to content

Commit b389d0b

Browse files
committed
refactor: drop several circular dependencies by removing unused headers
These unused headers has been found by running iwyu linter
1 parent f648039 commit b389d0b

File tree

4 files changed

+0
-12
lines changed

4 files changed

+0
-12
lines changed

src/logging.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
#include <fs.h>
77
#include <logging.h>
88
#include <util/string.h>
9-
#include <util/system.h>
109
#include <util/threadnames.h>
1110
#include <util/time.h>
1211

src/qt/guiutil.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#include <qt/bitcoinaddressvalidator.h>
1010
#include <qt/bitcoingui.h>
1111
#include <qt/bitcoinunits.h>
12-
#include <qt/optionsdialog.h>
1312
#include <qt/qvalidatedlineedit.h>
1413
#include <qt/sendcoinsrecipient.h>
1514

src/wallet/wallet.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
#include <wallet/coincontrol.h>
4343
#include <wallet/coinselection.h>
4444
#include <wallet/context.h>
45-
#include <wallet/fees.h>
4645
#include <warnings.h>
4746

4847
#include <coinjoin/common.h>

test/lint/lint-circular-dependencies.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"qt/addresstablemodel -> qt/walletmodel -> qt/addresstablemodel",
2020
"qt/recentrequeststablemodel -> qt/walletmodel -> qt/recentrequeststablemodel",
2121
"qt/transactiontablemodel -> qt/walletmodel -> qt/transactiontablemodel",
22-
"wallet/fees -> wallet/wallet -> wallet/fees",
2322
"wallet/wallet -> wallet/walletdb -> wallet/wallet",
2423
"node/coinstats -> validation -> node/coinstats",
2524
# Dash
@@ -59,21 +58,13 @@
5958
"llmq/signing -> llmq/signing_shares -> llmq/signing",
6059
"llmq/signing -> net_processing -> llmq/signing",
6160
"llmq/signing_shares -> net_processing -> llmq/signing_shares",
62-
"logging -> util/system -> logging",
63-
"logging -> util/system -> stacktraces -> logging",
64-
"logging -> util/system -> sync -> logging",
65-
"logging -> util/system -> sync -> logging/timer -> logging",
66-
"logging -> util/system -> util/getuniquepath -> random -> logging",
6761
"masternode/payments -> validation -> masternode/payments",
6862
"net -> netmessagemaker -> net",
6963
"net_processing -> spork -> net_processing",
7064
"netaddress -> netbase -> netaddress",
7165
"qt/appearancewidget -> qt/guiutil -> qt/appearancewidget",
72-
"qt/appearancewidget -> qt/guiutil -> qt/optionsdialog -> qt/appearancewidget",
7366
"qt/bitcoinaddressvalidator -> qt/guiutil -> qt/bitcoinaddressvalidator",
7467
"qt/bitcoingui -> qt/guiutil -> qt/bitcoingui",
75-
"qt/guiutil -> qt/optionsdialog -> qt/guiutil",
76-
"qt/guiutil -> qt/optionsdialog -> qt/optionsmodel -> qt/guiutil",
7768
"qt/guiutil -> qt/qvalidatedlineedit -> qt/guiutil",
7869
"wallet/coinjoin -> wallet/receive -> wallet/coinjoin",
7970
)

0 commit comments

Comments
 (0)