util, refactor: Drop explicit conversion to fs::path

hebasto · hebasto · commit b01f33670801 · 2022-04-21T12:55:31.000+02:00
Removes unhelpful noise/verbosity. See: bitcoin#24306 (comment)
diff --git a/src/util/system.cpp b/src/util/system.cpp
@@ -528,7 +528,7 @@ bool ArgsManager::InitSettings(std::string& error)
 
 bool ArgsManager::GetSettingsPath(fs::path* filepath, bool temp) const
 {
-    fs::path settings = GetPathArg("-settings", fs::path{BITCOIN_SETTINGS_FILENAME});
+    fs::path settings = GetPathArg("-settings", BITCOIN_SETTINGS_FILENAME);
     if (settings.empty()) {
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -528,7 +528,7 @@ bool ArgsManager::InitSettings(std::string& error)`
`528`	`528`
`529`	`529`	`bool ArgsManager::GetSettingsPath(fs::path* filepath, bool temp) const`
`530`	`530`	`{`
`531`		`- fs::path settings = GetPathArg("-settings", fs::path{BITCOIN_SETTINGS_FILENAME});`
	`531`	`+ fs::path settings = GetPathArg("-settings", BITCOIN_SETTINGS_FILENAME);`
`532`	`532`	`if (settings.empty()) {`
`533`	`533`	`return false;`
`534`	`534`	`}`