wallet: Fail if maximum weight is too large

Courtesy of 3e69939 from bitcoin#20536
dashpay · Feb 9, 2025 · ab756ba · ab756ba
1 parent 05c319e
commit ab756ba
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/wallet/spend.cpp b/src/wallet/spend.cpp
@@ -958,7 +958,8 @@ bool CWallet::CreateTransactionInternal(
         tx = MakeTransactionRef(std::move(txNew));
 
         // Limit size
-        if (static_cast<size_t>(nBytes) > MAX_STANDARD_TX_SIZE) {
+        if ((sign && ::GetSerializeSize(*tx, PROTOCOL_VERSION) > MAX_STANDARD_TX_SIZE) ||
+            (!sign && static_cast<size_t>(nBytes) > MAX_STANDARD_TX_SIZE)) {
             error = _("Transaction too large");
             return false;
         }