Cache heavy parts of CalcCbTxMerkleRoot*

Author: UdjinM6

src/evo/cbtx.cpp

@@ -92,27 +92,49 @@ bool CalcCbTxMerkleRootMNList(const CBlock& block, const CBlockIndex* pindexPrev
 
     CSimplifiedMNList sml(tmpMNList);
 
+    static CSimplifiedMNList smlCached;
+    static uint256 merkleRootCached;
+    static bool mutatedCached{false};
+
+    if (sml.mnList == smlCached.mnList) {
+        merkleRootRet = merkleRootCached;
+        return !mutatedCached;
+    }
+
     bool mutated = false;
     merkleRootRet = sml.CalcMerkleRoot(&mutated);
+    smlCached = std::move(sml);
+    merkleRootCached = merkleRootRet;
+    mutatedCached = mutated;
+
     return !mutated;
 }
 
 bool CalcCbTxMerkleRootQuorums(const CBlock& block, const CBlockIndex* pindexPrev, uint256& merkleRootRet, CValidationState& state)
 {
+    static std::map<Consensus::LLMQType, std::vector<const CBlockIndex*>> quorumsCached;
+    static std::map<Consensus::LLMQType, std::vector<uint256>> qcHashesCached;
+
     auto quorums = llmq::quorumBlockProcessor->GetMinedAndActiveCommitmentsUntilBlock(pindexPrev);
     std::map<Consensus::LLMQType, std::vector<uint256>> qcHashes;
     size_t hashCount = 0;
-    for (const auto& p : quorums) {
-        auto& v = qcHashes[p.first];
-        v.reserve(p.second.size());
-        for (const auto& p2 : p.second) {
-            llmq::CFinalCommitment qc;
-            uint256 minedBlockHash;
-            bool found = llmq::quorumBlockProcessor->GetMinedCommitment(p.first, p2->GetBlockHash(), qc, minedBlockHash);
-            assert(found);
-            v.emplace_back(::SerializeHash(qc));
-            hashCount++;
+    if (quorums == quorumsCached) {
+        qcHashes = qcHashesCached;
+    } else {
+        for (const auto& p : quorums) {
+            auto& v = qcHashes[p.first];
+            v.reserve(p.second.size());
+            for (const auto& p2 : p.second) {
+                llmq::CFinalCommitment qc;
+                uint256 minedBlockHash;
+                bool found = llmq::quorumBlockProcessor->GetMinedCommitment(p.first, p2->GetBlockHash(), qc, minedBlockHash);
+                assert(found);
+                v.emplace_back(::SerializeHash(qc));
+                hashCount++;
+            }
         }
+        quorumsCached = quorums;
+        qcHashesCached = qcHashes;
     }
 
     // now add the commitments from the current block, which are not returned by GetMinedAndActiveCommitmentsUntilBlock