Merge #6222: fix: adjust payee predictions after mn_rr activation, add tests

715bc1a test: check `masternode winners` before and after mn_rr (UdjinM6)
9d47cd2 fix: adjust payee predictions after mn_rr activation (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  Payment predictions in GUI are wrong when mn_rr is active, `masternode winners` RPC is affected by the same issue too. Actual payments aren't affected.

  ## What was done?
  Adjust calculations, add tests for `masternode winners`.

  ## How Has This Been Tested?
  Run dash-qt on testnet, check "Next Payment" on "Masternode" tab. Run tests.

  ## Breaking Changes
  n/a

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone

ACKs for top commit:
  PastaPastaPasta:
    utACK 715bc1a

Tree-SHA512: 293c77974bcb50c6f9c51449d7bb12f89ad8db5871cad3a6083fe1951fe77e0deba8de7688b2f600fabe977bdc7390a66a984a6a076be19183c23742e00e27bf

Author: PastaPastaPasta

src/evo/deterministicmns.cpp

@@ -215,15 +215,16 @@ std::vector<CDeterministicMNCPtr> CDeterministicMNList::GetProjectedMNPayees(gsl
     if (nCount < 0 ) {
         return {};
     }
-    const auto weighted_count = GetValidWeightedMNsCount();
+    const bool isMNRewardReallocation = DeploymentActiveAfter(pindexPrev, Params().GetConsensus(),
+                                                              Consensus::DEPLOYMENT_MN_RR);
+    const auto weighted_count = isMNRewardReallocation ? GetValidMNsCount() : GetValidWeightedMNsCount();
     nCount = std::min(nCount, int(weighted_count));
 
     std::vector<CDeterministicMNCPtr> result;
     result.reserve(weighted_count);
 
     int remaining_evo_payments{0};
     CDeterministicMNCPtr evo_to_be_skipped{nullptr};
-    const bool isMNRewardReallocation{DeploymentActiveAfter(pindexPrev, Params().GetConsensus(), Consensus::DEPLOYMENT_MN_RR)};
     if (!isMNRewardReallocation) {
         ForEachMNShared(true, [&](const CDeterministicMNCPtr& dmn) {
             if (dmn->pdmnState->nLastPaidHeight == nHeight) {
@@ -242,7 +243,7 @@ std::vector<CDeterministicMNCPtr> CDeterministicMNList::GetProjectedMNPayees(gsl
 
     ForEachMNShared(true, [&](const CDeterministicMNCPtr& dmn) {
         if (dmn == evo_to_be_skipped) return;
-        for ([[maybe_unused]] auto _ : irange::range(GetMnType(dmn->nType).voting_weight)) {
+        for ([[maybe_unused]] auto _ : irange::range(isMNRewardReallocation ? 1 : GetMnType(dmn->nType).voting_weight)) {
             result.emplace_back(dmn);
         }
     });

test/functional/feature_llmq_evo.py

@@ -17,7 +17,7 @@
     QuorumId, ser_uint256
 from test_framework.test_framework import DashTestFramework
 from test_framework.util import (
-    assert_equal, p2p_port
+    assert_equal, assert_greater_than_or_equal, p2p_port
 )
 
 
@@ -46,7 +46,7 @@ def getmnlistdiff(self, baseBlockHash, blockHash):
 
 class LLMQEvoNodesTest(DashTestFramework):
     def set_test_params(self):
-        self.set_dash_test_params(5, 4, fast_dip3_enforcement=True, evo_count=7)
+        self.set_dash_test_params(5, 4, fast_dip3_enforcement=True, evo_count=5)
         self.set_dash_llmq_test_params(4, 4)
 
     def run_test(self):
@@ -92,7 +92,7 @@ def run_test(self):
         self.mine_cycle_quorum(llmq_type_name='llmq_test_dip0024', llmq_type=103)
 
         evo_protxhash_list = list()
-        for i in range(5):
+        for i in range(self.evo_count):
             evo_info = self.dynamically_add_masternode(evo=True)
             evo_protxhash_list.append(evo_info.proTxHash)
             self.nodes[0].generate(8)
@@ -115,6 +115,7 @@ def run_test(self):
 
         self.log.info("Test that EvoNodes are paid 4x blocks in a row")
         self.test_evo_payments(window_analysis=48)
+        self.test_masternode_winners()
 
         self.activate_v20()
         self.activate_mn_rr()
@@ -127,6 +128,7 @@ def run_test(self):
 
         self.log.info("Test that EvoNodes are paid 1 block in a row after MN RewardReallocation activation")
         self.test_evo_payments(window_analysis=48, v20active=True)
+        self.test_masternode_winners(mn_rr_active=True)
 
         self.log.info(self.nodes[0].masternodelist())
 
@@ -248,6 +250,40 @@ def test_masternode_count(self, expected_mns_count, expected_evo_count):
         assert_equal(detailed_count['regular']['total'], expected_mns_count)
         assert_equal(detailed_count['evo']['total'], expected_evo_count)
 
+    def test_masternode_winners(self, mn_rr_active=False):
+        # ignore recent winners, test future ones only
+        # we get up to 21 entries here: tip + up to 20 future payees
+        winners = self.nodes[0].masternode('winners', '0')
+        weighted_count = self.mn_count + self.evo_count * (1 if mn_rr_active else 4)
+        assert_equal(len(winners.keys()) - 1, 20 if weighted_count > 20 else weighted_count)
+        consecutive_payments = 0
+        full_consecutive_payments_found = 0
+        payment_cycles = 0
+        first_payee = None
+        prev_winner = None
+        for height in winners.keys():
+            winner = winners[height]
+            if mn_rr_active:
+                assert_equal(prev_winner == winner, False)
+            else:
+                if prev_winner == winner:
+                    consecutive_payments += 1
+                else:
+                    if consecutive_payments == 3:
+                        full_consecutive_payments_found += 1
+                    consecutive_payments = 0
+                assert_greater_than_or_equal(3, consecutive_payments)
+            if consecutive_payments == 0 and winner == first_payee:
+                payment_cycles += 1
+            if first_payee is None:
+                first_payee = winner
+            prev_winner = winner
+        if mn_rr_active:
+            assert_equal(full_consecutive_payments_found, 0)
+        else:
+            assert_greater_than_or_equal(full_consecutive_payments_found, (len(winners.keys()) - 1 - self.mn_count) // 4 - 1)
+        assert_equal(payment_cycles, (len(winners.keys()) - 1) // weighted_count)
+
     def test_getmnlistdiff(self, baseBlockHash, blockHash, baseMNList, expectedDeleted, expectedUpdated):
         d = self.test_getmnlistdiff_base(baseBlockHash, blockHash)