Skip to content

Commit 8dac4b1

Browse files
Merge #6525: ci: add nowallet functional tests
1646525 ci: add nowallet functional tests (Konstantin Akimov) Pull request description: Many functional tests can be run if Dash Core is built as no-wallet, but we currently do not test whether they actually work in no-wallet mode. Additionally, many functional tests can run with a simple dummy wallet, increasing the number of functional tests that can run without a wallet. However, we also do not test this scenario. Now that extra functional tests have become available to run with the dummy-wallet MiniWallet (see #6520), we should finally add a job to our CI pipeline to run functional tests in no-wallet mode. Though using MiniWallet for DashTestFramework to let register masternodes without using a real Dash Core wallet currently impossible due to limitation of MiniWallet: Note that this method fails if there is no single internal utxo available that can cover the cost for the amount and the fixed fee (the utxo with the largest value is taken). This limitation may be addressed in future PRs, but it is out of scope for this PR. ## What was done? Add new CI job to run functional tests for nowallet. ## How Has This Been Tested? See CI: https://gitlab.com/dashpay/dash/-/jobs/8805673945 ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 1646525 kwvg: utACK 1646525 PastaPastaPasta: utACK 1646525 Tree-SHA512: c93ef92670886d3a5cf835681b55c264c757005c4af3146355e78808ab7e22fee30e5559218808bd381eb0a59bc01cc0ac69ce89dfd2d659e533392c33ac0a6a
2 parents 8debe7b + 1646525 commit 8dac4b1

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

.gitlab-ci.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,15 @@ linux64_multiprocess-test:
377377
variables:
378378
BUILD_TARGET: linux64_multiprocess
379379

380+
linux64_nowallet-test:
381+
extends:
382+
- .test-template
383+
- .skip-in-fast-mode-template
384+
needs:
385+
- linux64_nowallet-build
386+
variables:
387+
BUILD_TARGET: linux64_nowallet
388+
380389
#linux64_valgrind-test:
381390
# extends:
382391
# - .test-template

0 commit comments

Comments
 (0)