Skip to content

Commit 885e223

Browse files
committed
test: allow passing empty coreP2PAddrs to MasternodeInfo helpers
`or` will treat a blank string as a bad value and will go for the default, which creates problems when we need to test for blank value behaviors. This isn't a problem with `platform_{p2p,http}_port` since we check against None explicitly.
1 parent b69ca87 commit 885e223

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/functional/test_framework/test_framework.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1242,7 +1242,7 @@ def register(self, node: TestNode, submit: bool, collateral_txid: Optional[str]
12421242
args = [
12431243
collateral_txid or self.collateral_txid,
12441244
collateral_vout or self.collateral_vout,
1245-
addrs_core_p2p or [f'127.0.0.1:{self.nodePort}'],
1245+
[f'127.0.0.1:{self.nodePort}'] if addrs_core_p2p is None else addrs_core_p2p,
12461246
ownerAddr or self.ownerAddr,
12471247
pubKeyOperator or self.pubKeyOperator,
12481248
votingAddr or self.votingAddr,
@@ -1306,7 +1306,7 @@ def register_fund(self, node: TestNode, submit: bool, collateral_address: Option
13061306
# Common arguments shared between regular masternodes and EvoNodes
13071307
args = [
13081308
collateral_address or self.collateral_address,
1309-
addrs_core_p2p or [f'127.0.0.1:{self.nodePort}'],
1309+
[f'127.0.0.1:{self.nodePort}'] if addrs_core_p2p is None else addrs_core_p2p,
13101310
ownerAddr or self.ownerAddr,
13111311
pubKeyOperator or self.pubKeyOperator,
13121312
votingAddr or self.votingAddr,
@@ -1450,7 +1450,7 @@ def update_service(self, node: TestNode, submit: bool, addrs_core_p2p: Union[str
14501450
# Common arguments shared between regular masternodes and EvoNodes
14511451
args = [
14521452
self.proTxHash,
1453-
addrs_core_p2p or [f'127.0.0.1:{self.nodePort}'],
1453+
[f'127.0.0.1:{self.nodePort}'] if addrs_core_p2p is None else addrs_core_p2p,
14541454
self.keyOperator,
14551455
]
14561456
address_funds = fundsAddr or self.fundsAddr

0 commit comments

Comments
 (0)