Skip to content

Commit 772ec4c

Browse files
kwvgPastaPastaPasta
authored andcommitted
merge bitcoin#22305: Avoid fcntl64@GLIBC_2.28 in libsqlite3.a
1 parent 0fcc90c commit 772ec4c

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

contrib/devtools/symbol-check.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,19 @@
3333
# - libc version 2.28 (http://mirror.centos.org/centos/8-stream/AppStream/x86_64/os/Packages/)
3434
#
3535
# See https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html for more info.
36+
#
37+
# For 32-bit systems the minimum libc version is 2.28 to embrace new fcntl{64} symbols.
38+
# It is safer than handling them in the glibc_compat.cpp due to their variadic arguments
39+
# with possible different sizes.
40+
# See: https://stackoverflow.com/a/58472959
41+
#
3642

3743
MAX_VERSIONS = {
3844
'GCC': (4,8,0),
3945
'GLIBC': {
40-
pixie.EM_386: (2,18),
46+
pixie.EM_386: (2,28),
4147
pixie.EM_X86_64: (2,18),
42-
pixie.EM_ARM: (2,18),
48+
pixie.EM_ARM: (2,28),
4349
pixie.EM_AARCH64:(2,18),
4450
pixie.EM_PPC64: (2,18),
4551
pixie.EM_RISCV: (2,27),

0 commit comments

Comments
 (0)