evo: prohibit overwriting entry in MnNetInfo

Author: kwvg

src/evo/deterministicmns.cpp

@@ -1252,6 +1252,9 @@ static bool CheckService(const ProTx& proTx, TxValidationState& state)
         return state.Invalid(TxValidationResult::TX_BAD_SPECIAL, "bad-protx-netinfo-bad");
     case NetInfoStatus::Success:
         return true;
+    // Shouldn't be possible during self-checks
+    case NetInfoStatus::MaxLimit:
+        assert(false);
     } // no default case, so the compiler can warn about missing cases
     assert(false);
 }

src/evo/netinfo.cpp

@@ -148,6 +148,9 @@ NetInfoStatus MnNetInfo::ValidateService(const CService& service)
 
 NetInfoStatus MnNetInfo::AddEntry(const std::string& input)
 {
+    if (!IsEmpty()) {
+        return NetInfoStatus::MaxLimit;
+    }
     if (auto service = Lookup(input, /*portDefault=*/Params().GetDefaultPort(), /*fAllowLookup=*/false);
         service.has_value()) {
         const auto ret = ValidateService(service.value());

src/evo/netinfo.h

@@ -14,6 +14,10 @@
 class CService;
 
 enum class NetInfoStatus : uint8_t {
+    // Managing entries
+    MaxLimit,
+
+    // Validation
     BadAddress,
     BadInput,
     BadPort,
@@ -38,6 +42,8 @@ constexpr std::string_view NISToString(const NetInfoStatus code)
         return "unroutable address";
     case NetInfoStatus::Malformed:
         return "malformed";
+    case NetInfoStatus::MaxLimit:
+        return "too many entries";
     case NetInfoStatus::Success:
         return "success";
     } // no default case, so the compiler can warn about missing cases

src/test/evo_netinfo_tests.cpp

@@ -59,6 +59,14 @@ BOOST_AUTO_TEST_CASE(mnnetinfo_rules)
             ValidateGetEntries(netInfo.GetEntries(), /*expected_size=*/1);
         }
     }
+
+    {
+        // MnNetInfo only stores one value, overwriting prohibited
+        MnNetInfo netInfo;
+        BOOST_CHECK_EQUAL(netInfo.AddEntry("1.1.1.1:9999"), NetInfoStatus::Success);
+        BOOST_CHECK_EQUAL(netInfo.AddEntry("1.1.1.2:9999"), NetInfoStatus::MaxLimit);
+        ValidateGetEntries(netInfo.GetEntries(), /*expected_size=*/1);
+    }
 }
 
 bool CheckIfSerSame(const CService& lhs, const MnNetInfo& rhs)
@@ -83,6 +91,7 @@ BOOST_AUTO_TEST_CASE(cservice_compatible)
 
     // Valid IPv4 address, default P2P port implied
     service = LookupNumeric("1.1.1.1", Params().GetDefaultPort());
+    netInfo.Clear();
     BOOST_CHECK_EQUAL(netInfo.AddEntry("1.1.1.1"), NetInfoStatus::Success);
     BOOST_CHECK(CheckIfSerSame(service, netInfo));