Skip to content

Commit 6d8be28

Browse files
fanquakePastaPastaPasta
authored andcommitted
Merge bitcoin#22643: guix-verify: Non-zero exit code when anything fails
d451b60 guix-verify: Non-zero exit code when anything fails (Carl Dong) Pull request description: ``` Previously, if verification fails, the correct message will be printed, but the exit code would still be 0. ``` ACKs for top commit: achow101: ACK d451b60 Tree-SHA512: 695d72121f308d8a66db780eca16878fb378b4d766de5b58c2d6f778c5661a2f7bdf37a96e8e8e283b0a46b5d55f24bca05fa7509aa1822f0854c50064200572
1 parent 9ae8a00 commit 6d8be28

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

contrib/guix/guix-verify

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,13 @@ verify() {
7373
echo ""
7474
echo "Hint: Either the signature is invalid or the public key is missing"
7575
echo ""
76+
failure=1
7677
elif ! diff --report-identical "$compare_manifest" "$current_manifest" 1>&2; then
7778
echo "ERR: The SHA256SUMS attestation in these two directories differ:"
7879
echo " '${compare_manifest}'"
7980
echo " '${current_manifest}'"
8081
echo ""
82+
failure=1
8183
else
8284
echo "Verified: '${current_manifest}'"
8385
echo ""
@@ -140,3 +142,7 @@ if (( ${#all_noncodesigned[@]} + ${#all_all[@]} == 0 )); then
140142
echo ""
141143
exit 1
142144
fi
145+
146+
if [ -n "$failure" ]; then
147+
exit 1
148+
fi

0 commit comments

Comments
 (0)