refactor: delete extra ctors for netfulfilled, spork

Author: kwvg

src/netfulfilledman.cpp

@@ -12,6 +12,12 @@ CNetFulfilledRequestManager::CNetFulfilledRequestManager() :
 {
 }
 
+CNetFulfilledRequestManager::~CNetFulfilledRequestManager()
+{
+    if (!is_valid) return;
+    m_db->Store(*this);
+}
+
 bool CNetFulfilledRequestManager::LoadCache(bool load_cache)
 {
     assert(m_db != nullptr);
@@ -22,12 +28,6 @@ bool CNetFulfilledRequestManager::LoadCache(bool load_cache)
     return is_valid;
 }
 
-CNetFulfilledRequestManager::~CNetFulfilledRequestManager()
-{
-    if (!is_valid) return;
-    m_db->Store(*this);
-}
-
 void CNetFulfilledRequestManager::AddFulfilledRequest(const CService& addr, const std::string& strRequest)
 {
     LOCK(cs_mapFulfilledRequests);

src/netfulfilledman.h

@@ -50,7 +50,9 @@ class CNetFulfilledRequestManager : public NetFulfilledRequestStore
     bool is_valid{false};
 
 public:
-    explicit CNetFulfilledRequestManager();
+    CNetFulfilledRequestManager(const CNetFulfilledRequestManager&) = delete;
+    CNetFulfilledRequestManager& operator=(const CNetFulfilledRequestManager&) = delete;
+    CNetFulfilledRequestManager();
     ~CNetFulfilledRequestManager();
 
     bool LoadCache(bool load_cache);

src/spork.h

@@ -233,6 +233,8 @@ class CSporkManager : public SporkStore
     std::optional<SporkValue> SporkValueIfActive(SporkId nSporkID) const EXCLUSIVE_LOCKS_REQUIRED(cs, !cs_cache);
 
 public:
+    CSporkManager(const CSporkManager&) = delete;
+    CSporkManager& operator=(const CSporkManager&) = delete;
     CSporkManager();
     ~CSporkManager();