Skip to content

Commit 567771a

Browse files
Apply suggestions from code review
Co-authored-by: thephez <thephez@users.noreply.github.com>
1 parent 2b3211a commit 567771a

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

doc/release-notes.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ Updated REST APIs
6767
-----------------
6868

6969
- The `/headers/` and `/blockfilterheaders/` endpoints have been updated to use
70-
a query parameter instead of path parameter to specify the result count. The
71-
count parameter is now optional, and defaults to 5 for both endpoints. The old
70+
a query parameter instead of a path parameter to specify the result count. The
71+
count parameter is now optional and defaults to 5 for both endpoints. The old
7272
endpoints are still functional, and have no documented behaviour change. (#24098)
7373

7474
For `/headers`, use
@@ -92,10 +92,10 @@ Updated RPCs
9292
* The keys `platformP2PPort` and `platformHTTPPort` have been deprecated for the following RPCs, `decoderawtransaction`,
9393
`decodepsbt`, `getblock`, `getrawtransaction`, `gettransaction`, `masternode status` (only the `dmnState` key),
9494
`protx diff`, `protx listdiff` and has been replaced with the key `addresses`.
95-
* The deprecated key is still available without additional runtime arguments but is liable to be removed in future versions
95+
* The deprecated key is still available without additional runtime arguments, but is liable to be removed in future versions
9696
of Dash Core. (#6811)
9797

98-
* `protx revoke` will now use the legacy scheme version for legacy masternodes instead of the defaulting to the
98+
* `protx revoke` will now use the legacy scheme version for legacy masternodes instead of defaulting to the
9999
highest `ProUpRevTx` version. (#6729)
100100

101101
* The RPCs `protx register_legacy`, `protx register_fund_legacy`, `protx register_prepare_legacy` and
@@ -116,7 +116,7 @@ Updated RPCs
116116
`gettransaction`, `masternode status` (only for the `dmnState` key), `protx diff`, `protx listdiff`) and has been replaced
117117
with the key `addresses`.
118118
* This deprecation also extends to the functionally identical key, `address` in `masternode list` (and its alias, `masternodelist`).
119-
* The deprecated key is still available without additional runtime arguments but is liable to be removed in future versions
119+
* The deprecated key is still available without additional runtime arguments, but is liable to be removed in future versions
120120
of Dash Core.
121121
* This change does not affect `masternode status` (except for the `dmnState` key) as `service` does not represent a payload
122122
value but the external address advertised by the active masternode. (#6665)
@@ -138,7 +138,7 @@ Updated RPCs
138138
This does not affect `protx listdiff` queries where `netInfo` was updated or diffs relating to masternodes that
139139
have upgraded to extended addresses.
140140

141-
* If the masternode is eligible for extended addresses, `protx register{,_evo}` and `register_fund{,_evo}` will continue
141+
* If the masternode is eligible for extended addresses, `protx register{,_evo}` and `protx register_fund{,_evo}` will continue
142142
allowing `coreP2PAddrs` to be left blank, as long as `platformP2PAddrs` and `platformHTTPSAddrs` are also left blank.
143143
* Attempting to populate any three address fields will make populating all fields mandatory.
144144
* This does not affect nodes ineligible for extended addresses (i.e. all nodes before fork activation or legacy BLS nodes)
@@ -163,12 +163,12 @@ Updated RPCs
163163
changes to `netInfo` will not translate into reporting). This is because `platformP2PPort` or `platformHTTPPort` have
164164
dedicated diff flags and post-consolidation, all changes are now affected by `netInfo`'s diff flag.
165165

166-
To avoid the perception of changes to fields that not serialized by extended address payloads, data from `netInfo` will
166+
To avoid the perception of changes to fields that are not serialized by extended address payloads, data from `netInfo` will
167167
not be translated for this RPC call. (#6666)
168168

169169
* `quorum rotationinfo` will now expect the third param to be a JSON array. (#6628)
170170

171-
* `getislocks` will now return request `id` for each InstantSend Lock in results. (#6607)
171+
* `getislocks` will now return the request `id` for each InstantSend Lock in results. (#6607)
172172

173173
* `coinjoin status` is a new RPC that reports the status message of all running mix sessions. `coinjoin start` will no longer
174174
report errors from mix sessions; users are recommended to query the status using `coinjoin status` instead. (#6594)
@@ -177,7 +177,7 @@ Updated RPCs
177177

178178
* The `-deprecatedrpc=addresses` configuration option has been removed. RPCs `gettxout`, `getrawtransaction`, `decoderawtransaction`, `decodescript`, `gettransaction verbose=true` and REST endpoints `/rest/tx`, `/rest/getutxos`, `/rest/block` no longer return the `addresses` and `reqSigs` fields, which were previously deprecated in 21.0. (#22650)
179179

180-
* The `getblock` RPC command now supports verbosity level 3 containing transaction inputs `prevout` information. The existing `/rest/block/` REST endpoint is modified to contain this information too. Every `vin` field will contain an additional `prevout` subfield. (#22918)
180+
* The `getblock` RPC command now supports verbosity level 3, containing transaction inputs `prevout` information. The existing `/rest/block/` REST endpoint is modified to contain this information too. Every `vin` field will contain an additional `prevout` subfield. (#22918)
181181

182182
* A new RPC `newkeypool` has been added, which will flush (entirely clear and refill) the keypool. (#23093)
183183

@@ -204,7 +204,7 @@ Statistics
204204

205205
- IPv6 hosts are now supported by the StatsD client.
206206
- `-statshost` now accepts URLs to allow specifying the protocol, host and port in one argument.
207-
- Specifying invalid values will no longer result in silent disablement of the StatsD client and will now cause errors at startup. (#6837)
207+
- Specifying invalid values will no longer result in the silent disablement of the StatsD client and will now cause errors at startup. (#6837)
208208

209209
- The arguments `-statsenabled`, `-statsns`, `-statshostname` have been removed. They were previously deprecated in v22.0 and will no longer be recognized on runtime. (#6505)
210210

@@ -229,13 +229,13 @@ Wallet
229229

230230
### Mobile CoinJoin Compatibility
231231

232-
- Fixed an issue where CoinJoin funds mixed in Dash Android wallet were invisible when importing the mnemonic into Dash Core. Descriptor Wallets now include an additional default descriptor for mobile CoinJoin funds, ensuring seamless wallet migration and complete fund visibility across different Dash wallet implementations.
232+
- Fixed an issue where CoinJoin funds mixed in the Dash Android wallet were invisible when importing the mnemonic into Dash Core. Descriptor Wallets now include an additional default descriptor for mobile CoinJoin funds, ensuring seamless wallet migration and complete fund visibility across different Dash wallet implementations.
233233
- This is a breaking change that increases the default number of descriptors from 2 to 3 on mainnet (internal, external, mobile CoinJoin) for newly created descriptor wallets only - existing wallets are unaffected. (#6835)
234234

235235
GUI changes
236236
-----------
237237

238-
- Added governance proposal voting functionality to the Qt interface. Users with masternode voting keys can now vote on governance proposals directly from the governance tab via right-click context menu. Added masternode count display to governance tab showing how many masternodes the wallet can vote with. (#6690)
238+
- Added governance proposal voting functionality to the Qt interface. Users with masternode voting keys can now vote on governance proposals directly from the governance tab via right-click context menu. Added masternode count display to governance tab, showing how many masternodes the wallet can vote with. (#6690)
239239
- Added a menu item to restore a wallet from a backup file. (#6648)
240240

241241
RPC Wallet

0 commit comments

Comments
 (0)