refactor: move dtor to source file, delete extra ctors for notif int.

Author: kwvg

src/dsnotificationinterface.cpp

@@ -27,16 +27,18 @@ CDSNotificationInterface::CDSNotificationInterface(CConnman& connman,
                                                    const ChainstateManager& chainman,
                                                    const std::unique_ptr<CDeterministicMNManager>& dmnman,
                                                    const std::unique_ptr<LLMQContext>& llmq_ctx) :
-    m_connman(connman),
-    m_dstxman(dstxman),
-    m_mn_sync(mn_sync),
-    m_govman(govman),
-    m_chainman(chainman),
-    m_dmnman(dmnman),
-    m_llmq_ctx(llmq_ctx)
+    m_connman{connman},
+    m_dstxman{dstxman},
+    m_mn_sync{mn_sync},
+    m_govman{govman},
+    m_chainman{chainman},
+    m_dmnman{dmnman},
+    m_llmq_ctx{llmq_ctx}
 {
 }
 
+CDSNotificationInterface::~CDSNotificationInterface() = default;
+
 void CDSNotificationInterface::InitializeCurrentBlockTip()
 {
     SynchronousUpdatedBlockTip(m_chainman.ActiveChain().Tip(), nullptr, m_chainman.ActiveChainstate().IsInitialBlockDownload());

src/dsnotificationinterface.h

@@ -18,14 +18,17 @@ struct LLMQContext;
 class CDSNotificationInterface : public CValidationInterface
 {
 public:
+    CDSNotificationInterface() = delete;
+    CDSNotificationInterface(const CDSNotificationInterface&) = delete;
+    CDSNotificationInterface& operator=(const CDSNotificationInterface&) = delete;
     explicit CDSNotificationInterface(CConnman& connman,
                                       CDSTXManager& dstxman,
                                       CMasternodeSync& mn_sync,
                                       CGovernanceManager& govman,
                                       const ChainstateManager& chainman,
                                       const std::unique_ptr<CDeterministicMNManager>& dmnman,
                                       const std::unique_ptr<LLMQContext>& llmq_ctx);
-    virtual ~CDSNotificationInterface() = default;
+    virtual ~CDSNotificationInterface();
 
     // a small helper to initialize current block height in sub-modules on startup
     void InitializeCurrentBlockTip();

src/masternode/active/notificationinterface.cpp

@@ -16,6 +16,8 @@ ActiveNotificationInterface::ActiveNotificationInterface(ActiveContext& active_c
 {
 }
 
+ActiveNotificationInterface::~ActiveNotificationInterface() = default;
+
 void ActiveNotificationInterface::UpdatedBlockTip(const CBlockIndex* pindexNew, const CBlockIndex* pindexFork,
                                                   bool fInitialDownload)
 {

src/masternode/active/notificationinterface.h

@@ -20,8 +20,9 @@ class ActiveNotificationInterface final : public CValidationInterface
 public:
     ActiveNotificationInterface() = delete;
     ActiveNotificationInterface(const ActiveNotificationInterface&) = delete;
+    ActiveNotificationInterface& operator=(const ActiveNotificationInterface&) = delete;
     explicit ActiveNotificationInterface(ActiveContext& active_ctx, CActiveMasternodeManager& mn_activeman);
-    virtual ~ActiveNotificationInterface() = default;
+    virtual ~ActiveNotificationInterface();
 
 protected:
     // CValidationInterface