qt, refactor: Replace BitcoinGUI::macosDockIconActivated with a lambda

Author: hebasto

src/qt/bitcoingui.cpp

@@ -801,8 +801,10 @@ void BitcoinGUI::setClientModel(ClientModel *_clientModel, interfaces::BlockAndH
             // Note: on macOS, the Dock icon is also used to provide menu functionality
             // similar to one for tray icon
             MacDockIconHandler *dockIconHandler = MacDockIconHandler::instance();
-            connect(dockIconHandler, &MacDockIconHandler::dockIconClicked, this, &BitcoinGUI::macosDockIconActivated);
-
+            connect(dockIconHandler, &MacDockIconHandler::dockIconClicked, [this] {
+                showNormalIfMinimized();
+                activateWindow();
+            });
             dockIconMenu = new QMenu(this);
             dockIconMenu->setAsDockMenu();
 
@@ -1075,12 +1077,6 @@ void BitcoinGUI::trayIconActivated(QSystemTrayIcon::ActivationReason reason)
         toggleHidden();
     }
 }
-#else
-void BitcoinGUI::macosDockIconActivated()
-{
-    showNormalIfMinimized();
-    activateWindow();
-}
 #endif
 
 void BitcoinGUI::optionsClicked()

src/qt/bitcoingui.h

@@ -374,9 +374,6 @@ public Q_SLOTS:
 #ifndef Q_OS_MAC
     /** Handle tray icon clicked */
     void trayIconActivated(QSystemTrayIcon::ActivationReason reason);
-#else
-    /** Handle macOS Dock icon clicked */
-    void macosDockIconActivated();
 #endif
 
     /** Show window if hidden, unminimize when minimized, rise when obscured or show if hidden and fToggleHidden is true */