Skip to content

Commit 3c70eb0

Browse files
Merge #6112: refactor: remove unused includes from unit tests
e65984e refactor: remove unused includes from unit tests (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented Noticed there were some not used includes in Unit tests and removed them. It's not exhaustive list of unused headers, just something that was easy to spot. ## How Has This Been Tested? Just build and see that there's no build error. This PR also slightly reduced compilation time of project, it's measurable big changes to6-8 seconds of one CPU core faster. Tested by compiling only files that changed in single-thread: ``` $ rm src/test/test_dash-blockfilter_index_tests.o src/test/test_dash-block_reward_reallocation_tests.o src/test/test_dash-denialofservice_tests.o src/test/test_dash-dynamic_activation_thresholds_tests.o src/test/test_dash-validation_block_tests.o src/test/test_dash-validation_chainstate_tests.o src/test/test_dash-validation_flush_tests.o src/test/util/libtest_util_a-mining.o src/test/util/libtest_util_a-setup_common.o $ cd src/test ; time make -j1 ``` ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK e65984e PastaPastaPasta: utACK e65984e Tree-SHA512: 445c1515aee09e946eb73f12ca9c8064d26cd6148d2286fa079bf54806ea77af9eda890a36c8f34450791e868fbe933183bc7e507dd6e667304ccd92790bb009
2 parents 04adca3 + e65984e commit 3c70eb0

9 files changed

+1
-40
lines changed

src/test/block_reward_reallocation_tests.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,12 @@
1515
#include <script/sign.h>
1616
#include <script/signingprovider.h>
1717
#include <script/standard.h>
18-
#include <spork.h>
1918
#include <validation.h>
2019

2120
#include <evo/deterministicmns.h>
2221
#include <evo/mnhftx.h>
2322
#include <evo/providertx.h>
2423
#include <evo/specialtx.h>
25-
#include <governance/governance.h>
26-
#include <llmq/blockprocessor.h>
27-
#include <llmq/chainlocks.h>
28-
#include <llmq/context.h>
29-
#include <llmq/instantsend.h>
3024
#include <masternode/payments.h>
3125
#include <util/enumerate.h>
3226
#include <util/irange.h>

src/test/blockfilter_index_tests.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,7 @@
55
#include <blockfilter.h>
66
#include <chainparams.h>
77
#include <consensus/validation.h>
8-
#include <evo/evodb.h>
9-
#include <governance/governance.h>
108
#include <index/blockfilterindex.h>
11-
#include <llmq/blockprocessor.h>
12-
#include <llmq/chainlocks.h>
13-
#include <llmq/context.h>
14-
#include <llmq/instantsend.h>
159
#include <miner.h>
1610
#include <pow.h>
1711
#include <script/standard.h>

src/test/denialofservice_tests.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66

77
#include <banman.h>
88
#include <chainparams.h>
9-
#include <evo/deterministicmns.h>
10-
#include <llmq/context.h>
119
#include <net.h>
1210
#include <net_processing.h>
1311
#include <pubkey.h>
@@ -20,7 +18,6 @@
2018
#include <util/system.h>
2119
#include <util/time.h>
2220
#include <validation.h>
23-
#include <governance/governance.h>
2421

2522
#include <array>
2623
#include <stdint.h>

src/test/dynamic_activation_thresholds_tests.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,6 @@
77
#include <chainparams.h>
88
#include <consensus/validation.h>
99
#include <deploymentstatus.h>
10-
#include <evo/evodb.h>
11-
#include <governance/governance.h>
12-
#include <llmq/blockprocessor.h>
13-
#include <llmq/chainlocks.h>
14-
#include <llmq/context.h>
15-
#include <llmq/instantsend.h>
1610
#include <miner.h>
1711
#include <script/interpreter.h>
1812
#include <spork.h>

src/test/util/mining.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,7 @@
77
#include <chainparams.h>
88
#include <consensus/merkle.h>
99
#include <evo/evodb.h>
10-
#include <governance/governance.h>
1110
#include <key_io.h>
12-
#include <llmq/blockprocessor.h>
13-
#include <llmq/chainlocks.h>
14-
#include <llmq/context.h>
15-
#include <llmq/instantsend.h>
1611
#include <miner.h>
1712
#include <node/context.h>
1813
#include <pow.h>

src/test/util/setup_common.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@
1818
#include <init.h>
1919
#include <interfaces/chain.h>
2020
#include <netfulfilledman.h>
21-
#include <llmq/blockprocessor.h>
2221
#include <llmq/chainlocks.h>
2322
#include <llmq/context.h>
24-
#include <llmq/dkgsessionmgr.h>
2523
#include <llmq/instantsend.h>
2624
#include <llmq/quorums.h>
2725
#include <llmq/signing.h>
@@ -58,11 +56,9 @@
5856

5957
#include <bls/bls.h>
6058
#ifdef ENABLE_WALLET
61-
#include <coinjoin/client.h>
59+
#include <interfaces/coinjoin.h>
6260
#endif // ENABLE_WALLET
63-
#include <coinjoin/coinjoin.h>
6461
#include <coinjoin/context.h>
65-
#include <coinjoin/server.h>
6662
#include <evo/cbtx.h>
6763
#include <evo/chainhelper.h>
6864
#include <evo/creditpool.h>

src/test/validation_block_tests.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,10 @@
88
#include <consensus/consensus.h>
99
#include <consensus/merkle.h>
1010
#include <consensus/validation.h>
11-
#include <evo/evodb.h>
12-
#include <governance/governance.h>
13-
#include <llmq/blockprocessor.h>
14-
#include <llmq/chainlocks.h>
15-
#include <llmq/context.h>
16-
#include <llmq/instantsend.h>
1711
#include <miner.h>
1812
#include <pow.h>
1913
#include <random.h>
2014
#include <script/standard.h>
21-
#include <spork.h>
2215
#include <test/util/script.h>
2316
#include <test/util/setup_common.h>
2417
#include <util/time.h>

src/test/validation_chainstate_tests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#include <consensus/validation.h>
66
#include <evo/evodb.h>
77
#include <index/txindex.h>
8-
#include <llmq/blockprocessor.h>
98
#include <llmq/chainlocks.h>
109
#include <llmq/instantsend.h>
1110
#include <random.h>

src/test/validation_flush_tests.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
44
//
55
#include <evo/evodb.h>
6-
#include <llmq/blockprocessor.h>
76
#include <llmq/chainlocks.h>
87
#include <llmq/instantsend.h>
98
#include <sync.h>

0 commit comments

Comments
 (0)