Merge #6856: backport: bitcoin#21626, bitcoin#24203, bitcoin#25200 (spelling errors)

00f1ceb fix: some typos and mispells by linter for dash specific code (Konstantin Akimov)
9f01400 Merge bitcoin#25200: doc: Fix spelling errors identified by codespell in comments (MacroFake)
6753e26 Merge bitcoin#21626: doc: Fix typos from codespell (fanquake)
60d9516 Merge bitcoin#24203: doc: Fix typos pointed out by lint-spelling (MarcoFalke)

Pull request description:

  ## Issue being fixed or feature implemented
  Output of spelling linter is pretty long and dirty, this PR clear it up a bit

  ## What was done?
  Backports + extra fixes for Dash specific code

  ## How Has This Been Tested?
  Reviewed output of https://github.com/dashpay/dash/actions/runs/18056747144/job/51387575631?pr=6855

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  kwvg:
    utACK 00f1ceb

Tree-SHA512: c7aa47ef70fb96efdac58cbcf3d32de41940e903e6c9318bd16f7ae72599abd6439c0bd154b1a231e720cc9767fe4be129a07bac0d1bdb3f26cff92ed255af9f

Author: PastaPastaPasta

configure.ac

@@ -355,7 +355,7 @@ case $host in
 esac
 
 if test "$enable_debug" = "yes"; then
-  dnl If debugging is enabled, and the user hasn't overriden CXXFLAGS, clear
+  dnl If debugging is enabled, and the user hasn't overridden CXXFLAGS, clear
   dnl them, to prevent autoconfs "-g -O2" being added. Otherwise we'd end up
   dnl with "-O0 -g3 -g -O2".
   if test "$CXXFLAGS_overridden" = "no"; then
@@ -1003,7 +1003,7 @@ if test "$use_lcov" = "yes"; then
     [AC_MSG_ERROR([lcov testing requested but --coverage linker flag does not work])])
   AX_CHECK_COMPILE_FLAG([--coverage],[CORE_CXXFLAGS="$CORE_CXXFLAGS --coverage"],
     [AC_MSG_ERROR([lcov testing requested but --coverage flag does not work])])
-  dnl If coverage is enabled, and the user hasn't overriden CXXFLAGS, clear
+  dnl If coverage is enabled, and the user hasn't overridden CXXFLAGS, clear
   dnl them, to prevent autoconfs "-g -O2" being added. Otherwise we'd end up
   dnl with "--coverage -Og -O0 -g -O2".
   if test "$CXXFLAGS_overridden" = "no"; then

src/evo/netinfo.cpp

@@ -323,7 +323,7 @@ NetInfoStatus ExtNetInfo::ProcessCandidate(const NetInfoPurpose purpose, const N
         assert(status); // We did just check to see if our value already existed, try_emplace shouldn't fail
     }
 
-    // Candidate succesfully added, update cache
+    // Candidate successfully added, update cache
     m_all_entries.push_back(candidate);
     return NetInfoStatus::Success;
 }

src/masternode/payments.cpp

@@ -41,7 +41,7 @@ CAmount PlatformShare(const CAmount reward)
     CAmount masternodeReward = GetMasternodePayment(nBlockHeight, blockSubsidy + feeReward, fV20Active);
 
     // Credit Pool doesn't exist before V20. If any part of reward will re-allocated to credit pool before v20
-    // activation these fund will be just permanently lost. Applyable for devnets, regtest, testnet
+    // activation these fund will be just permanently lost. Applicable for devnets, regtest, testnet
     if (fV20Active && DeploymentActiveAfter(pindexPrev, m_consensus_params, Consensus::DEPLOYMENT_MN_RR)) {
         CAmount masternodeSubsidyReward = GetMasternodePayment(nBlockHeight, blockSubsidy, fV20Active);
         const CAmount platformReward = PlatformShare(masternodeSubsidyReward);

src/net.cpp

@@ -1021,7 +1021,7 @@ const std::array<std::string, 40> V2_DASH_IDS = {
 
 /** A complete set of short IDs
  *
- * Bitcoin takes up short IDs upto 128 (lower half) while Dash can take
+ * Bitcoin takes up short IDs up to 128 (lower half) while Dash can take
  * up short IDs between 128 and 256 (upper half) most of the array will
  * have entries that correspond to nothing.
  *

src/random.h

@@ -103,7 +103,7 @@ constexpr auto GetRandMillis = GetRandomDuration<std::chrono::milliseconds>;
  * is memoryless and should be used for repeated network events (e.g. sending a
  * certain type of message) to minimize leaking information to observers.
  *
- * The probability of an event occuring before time x is 1 - e^-(x/a) where a
+ * The probability of an event occurring before time x is 1 - e^-(x/a) where a
  * is the average interval between events.
  * */
 std::chrono::microseconds GetExponentialRand(std::chrono::microseconds now, std::chrono::seconds average_interval);

src/rpc/blockchain.cpp

@@ -481,10 +481,10 @@ static RPCHelpMan getblockfrompeer()
 {
     return RPCHelpMan{
         "getblockfrompeer",
-        "Attempt to fetch block from a given peer.\n"
-        "\nWe must have the header for this block, e.g. using submitheader.\n"
-        "Subsequent calls for the same block and a new peer will cause the response from the previous peer to be ignored.\n"
-        "\nReturns an empty JSON object if the request was successfully scheduled.",
+        "Attempt to fetch block from a given peer.\n\n"
+        "We must have the header for this block, e.g. using submitheader.\n"
+        "Subsequent calls for the same block and a new peer will cause the response from the previous peer to be ignored.\n\n"
+        "Returns an empty JSON object if the request was successfully scheduled.",
         {
             {"blockhash", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The block hash to try to fetch"},
             {"peer_id", RPCArg::Type::NUM, RPCArg::Optional::NO, "The peer to fetch it from (see getpeerinfo for peer IDs)"},

src/rpc/rawtransaction_util.h

@@ -32,7 +32,7 @@ void SignTransactionResultToJSON(CMutableTransaction& mtx, bool complete, const
   * Parse a prevtxs UniValue array and get the map of coins from it
   *
   * @param  prevTxsUnival Array of previous txns outputs that tx depends on but may not yet be in the block chain
-  * @param  keystore      A pointer to the temprorary keystore if there is one
+  * @param  keystore      A pointer to the temporary keystore if there is one
   * @param  coins         Map of unspent outputs - coins in mempool and current chain UTXO set, may be extended by previous txns outputs after call
   */
 void ParsePrevouts(const UniValue& prevTxsUnival, FillableSigningProvider* keystore, std::map<COutPoint, Coin>& coins);

src/sync.h

@@ -144,7 +144,7 @@ using RecursiveMutex = AnnotatedMixin<std::recursive_mutex>;
 /** Wrapped mutex: supports waiting but not recursive locking */
 using Mutex = AnnotatedMixin<std::mutex>;
 
-/** Wrapped shared mutex: supports read locking via .shared_lock, exlusive locking via .lock;
+/** Wrapped shared mutex: supports read locking via .shared_lock, exclusive locking via .lock;
  * does not support recursive locking */
 using SharedMutex = SharedAnnotatedMixin<std::shared_mutex>;
 

src/test/coinjoin_queue_tests.cpp

@@ -15,7 +15,7 @@ BOOST_FIXTURE_TEST_SUITE(coinjoin_queue_tests, BasicTestingSetup)
 
 static CBLSSecretKey MakeSecretKey()
 {
-    // Generate a dummy operator keypair for signing
+    // Generate a dummy operator key pair for signing
     CBLSSecretKey sk;
     sk.MakeNewKey();
     return sk;

src/test/fuzz/tx_pool.cpp

@@ -47,7 +47,7 @@ void initialize_tx_pool()
 
     for (int i = 0; i < 2 * COINBASE_MATURITY; ++i) {
         CTxIn in = MineBlock(g_setup->m_node, CScript() << OP_TRUE);
-        // Remember the txids to avoid expensive disk acess later on
+        // Remember the txids to avoid expensive disk access later on
         auto& outpoints = i < COINBASE_MATURITY ?
                               g_outpoints_coinbase_init_mature :
                               g_outpoints_coinbase_init_immature;