Skip to content

Commit 21470fd

Browse files
committed
merge bitcoin#25292: Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf section in dev notes
1 parent 026409e commit 21470fd

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

doc/developer-notes.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -862,11 +862,6 @@ int GetInt(Tabs tab)
862862
Strings and formatting
863863
------------------------
864864
865-
- Be careful of `LogPrint` versus `LogPrintf`. `LogPrint` takes a `category` argument, `LogPrintf` does not.
866-
867-
- *Rationale*: Confusion of these can result in runtime exceptions due to
868-
formatting mismatch, and it is easy to get wrong because of subtly similar naming.
869-
870865
- Use `std::string`, avoid C string manipulation functions.
871866
872867
- *Rationale*: C++ string handling is marginally safer, less scope for

test/lint/lint-format-strings.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS=(
1717
"LogConnectFailure,1"
1818
"LogPrint,1"
1919
"LogPrintf,0"
20+
"LogPrintLevel,2"
2021
"printf,0"
2122
"snprintf,2"
2223
"sprintf,1"

0 commit comments

Comments
 (0)