Skip to content

Commit 184b463

Browse files
committed
fix: resolve -Wdelete-non-abstract-non-virtual-dtor warnings
1 parent 53d29e9 commit 184b463

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/coinjoin/coinjoin.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ class CCoinJoinBaseSession
317317
int nSessionDenom{0}; // Users must submit a denom matching this
318318

319319
CCoinJoinBaseSession() = default;
320+
virtual ~CCoinJoinBaseSession() = default;
320321

321322
int GetState() const { return nState; }
322323
std::string GetStateString() const;

src/versionbits.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,13 +107,16 @@ class AbstractEHFManager
107107
public:
108108
using Signals = std::unordered_map<uint8_t, int>;
109109

110+
public:
111+
AbstractEHFManager() = default;
112+
virtual ~AbstractEHFManager() = default;
113+
110114
/**
111115
* getInstance() is used in versionbit because it is non-trivial
112116
* to get access to NodeContext from all usages of VersionBits* methods
113117
* For simplification of interface this methods static/global variable is used
114118
* to get access to EHF data
115119
*/
116-
public:
117120
[[nodiscard]] static gsl::not_null<AbstractEHFManager*> getInstance() {
118121
return globalInstance;
119122
};
@@ -127,7 +130,6 @@ class AbstractEHFManager
127130
*/
128131
virtual Signals GetSignalsStage(const CBlockIndex* const pindexPrev) = 0;
129132

130-
131133
protected:
132134
static AbstractEHFManager* globalInstance;
133135
};

0 commit comments

Comments
 (0)