fix: correct simplifiedmns_merkleroots unit test

In the next commit, we are going to enforce validation the moment we
to set values. That will break this test because this test makes two
errors.

- It tries to use non-mainnet ports on BasicTestingSetup (which is
  mainnet), resolved by using RegTest.
- It constructs the IP 0.0.0.0, which is not a routable address, resolved
  by counting from 1 onwards.

Author: kwvg

src/test/evo_simplifiedmns_tests.cpp

@@ -10,14 +10,14 @@
 
 #include <boost/test/unit_test.hpp>
 
-BOOST_FIXTURE_TEST_SUITE(evo_simplifiedmns_tests, BasicTestingSetup)
+BOOST_FIXTURE_TEST_SUITE(evo_simplifiedmns_tests, RegTestingSetup)
 
 BOOST_AUTO_TEST_CASE(simplifiedmns_merkleroots)
 {
     //TODO: Provide raw data for basic scheme as well
     bls::bls_legacy_scheme.store(true);
     std::vector<CSimplifiedMNListEntry> entries;
-    for (size_t i = 0; i < 15; i++) {
+    for (size_t i = 1; i < 16; i++) {
         CSimplifiedMNListEntry smle;
         smle.proRegTxHash.SetHex(strprintf("%064x", i));
         smle.confirmedHash.SetHex(strprintf("%064x", i));
@@ -35,7 +35,6 @@ BOOST_AUTO_TEST_CASE(simplifiedmns_merkleroots)
     }
 
     std::vector<std::string> expectedHashes = {
-        "373b549f6380d8f7b04d7b04d7c58a749c5cbe3bf41536785ba819879c4870f1",
         "3a1010e28226558560e5296bcee6bf0b9b963b73a1514f5aa2885e270f6b90c1",
         "85d3d93b28689128daf3a41d706ae5002f447b9b6372776f0ca9d53b31146884",
         "8930eee6bd2e7971a7090edfb79f74c00a12280e59adfc2cc99d406a01e368f9",
@@ -50,6 +49,7 @@ BOOST_AUTO_TEST_CASE(simplifiedmns_merkleroots)
         "cbc25ca965d0fa69a1fdc1d796b8ee2726a0e2137414e92fb9541630e3189901",
         "ac9934c4049ae952d41fb38e7e9659a558a5ce748bdb7fb613741598d1b16a27",
         "a61177eb14450bb8c56e5f0547035e0f3a70fe46f36901351cc568b2e48e29d0",
+        "67798d40a2196f446114c68d86445fe088750515a96eb65392c6bcfac8f3be9b"
     };
     std::vector<std::string> calculatedHashes;
 
@@ -62,7 +62,7 @@ BOOST_AUTO_TEST_CASE(simplifiedmns_merkleroots)
 
     CSimplifiedMNList sml(entries);
 
-    std::string expectedMerkleRoot = "b2303aca677ae2091c882e44b58f57869fa88a6db1f4e1a5d71975e5387fa195";
+    std::string expectedMerkleRoot = "0bae2176078cf42fa3e1fda761d4255d1c1c54777c6a793d0ab2b07c85ed4022";
     std::string calculatedMerkleRoot = sml.CalcMerkleRoot(nullptr).ToString();
     //printf("merkleRoot=\"%s\",\n", calculatedMerkleRoot.c_str());