fix(dashspend): add error handing for purchase limit mismatch (#1390)

HashEngineering · coderabbitai[bot] · web-flow · commit c6e05e7c9f0b · 2025-05-20T09:25:41.000-07:00
* fix: add error handing for limit mismatch

* fix: improve error checking on errorBody decoding

Co-authored-by: coderabbitai[bot] &lt;136622811+coderabbitai[bot]@users.noreply.github.com&gt;

* chore: ktlint

* fix: fix limit error detection (min, max)

* tests: add CTXSpendExceptionTest for limit errors

* tests: add CTXSpendExceptionTest for malformed errorBody

* style: ktlint

---------

Co-authored-by: coderabbitai[bot] &lt;136622811+coderabbitai[bot]@users.noreply.github.com&gt;
diff --git a/common/src/main/res/values/strings.xml b/common/src/main/res/values/strings.xml
@@ -110,6 +110,7 @@
     <string name="log_in">Log In</string>
 
     <string name="chain_syncing">The chain is syncing…</string>
+    <string name="report_issue_dialog_mail_intent_chooser">Send report using…</string>
 
     <!-- basic formats -->
     <string name="percent" translatable="false">%d%%</string>
diff --git a/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/repository/CTXSpendRepository.kt b/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/repository/CTXSpendRepository.kt
@@ -17,6 +17,8 @@
 
 package org.dash.wallet.features.exploredash.repository
 
+import com.google.gson.Gson
+import com.google.gson.reflect.TypeToken
 import kotlinx.coroutines.flow.Flow
 import org.dash.wallet.common.data.ResponseResource
 import org.dash.wallet.common.data.safeApiCall
@@ -31,12 +33,36 @@ import org.dash.wallet.features.exploredash.utils.CTXSpendConfig
 import java.util.UUID
 import javax.inject.Inject
 
-class CTXSpendException(message: String) : Exception(message) {
+class CTXSpendException(
+    message: String,
+    val errorCode: Int? = null,
+    val errorBody: String? = null
+) : Exception(message) {
     var resourceString: ResourceString? = null
+    private val errorMap: Map<String, Any>
 
     constructor(message: ResourceString) : this("") {
         this.resourceString = message
     }
+
+    init {
+        val type = object : TypeToken<Map<String, Any>>() {}.type
+        errorMap = try {
+            if (errorBody != null) {
+                Gson().fromJson(errorBody, type) ?: emptyMap()
+            } else {
+                emptyMap()
+            }
+        } catch (e: Exception) {
+            emptyMap()
+        }
+    }
+
+    val isLimitError: Boolean
+        get() {
+            val fiatAmount = ((errorMap["fields"] as? Map<*, *>)?.get("fiatAmount") as? List<*>)?.firstOrNull()
+            return errorCode == 400 && (fiatAmount == "above threshold" || fiatAmount == "below threshold")
+        }
 }
 
 class CTXSpendRepository @Inject constructor(
diff --git a/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/ctxspend/CTXSpendViewModel.kt b/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/ctxspend/CTXSpendViewModel.kt
@@ -17,6 +17,7 @@
 
 package org.dash.wallet.features.exploredash.ui.ctxspend
 
+import android.content.Intent
 import androidx.lifecycle.*
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
@@ -51,6 +52,7 @@ import org.dash.wallet.features.exploredash.data.explore.GiftCardDao
 import org.dash.wallet.features.exploredash.data.explore.model.Merchant
 import org.dash.wallet.features.exploredash.repository.CTXSpendException
 import org.dash.wallet.features.exploredash.repository.CTXSpendRepositoryInt
+import org.dash.wallet.features.exploredash.utils.CTXSpendConstants
 import org.slf4j.LoggerFactory
 import javax.inject.Inject
 
@@ -137,8 +139,13 @@ class CTXSpendViewModel @Inject constructor(
                 }
                 is ResponseResource.Failure -> {
                     log.error("purchaseGiftCard error ${response.errorCode}: ${response.errorBody}")
-                    throw CTXSpendException("purchaseGiftCard error ${response.errorCode}: ${response.errorBody}")
+                    throw CTXSpendException(
+                        "purchaseGiftCard error ${response.errorCode}: ${response.errorBody}",
+                        response.errorCode,
+                        response.errorBody
+                    )
                 }
+                // else -> {}
             }
         }
         throw CTXSpendException("purchaseGiftCard error")
@@ -272,4 +279,44 @@ class CTXSpendViewModel @Inject constructor(
     fun logEvent(eventName: String) {
         analytics.logEvent(eventName, mapOf())
     }
+
+    fun createEmailIntent(
+        subject: String,
+        ex: CTXSpendException
+    ) = Intent(Intent.ACTION_SEND).apply {
+        setType("message/rfc822")
+        putExtra(Intent.EXTRA_EMAIL, arrayOf(CTXSpendConstants.REPORT_EMAIL))
+        putExtra(Intent.EXTRA_SUBJECT, subject)
+        putExtra(Intent.EXTRA_TEXT, createReportEmail(ex))
+        addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION)
+    }
+
+    fun createReportEmail(ex: CTXSpendException): String {
+        val report = StringBuilder()
+        report.append("CTX Issue Report").append("\n")
+        if (this::giftCardMerchant.isInitialized) {
+            report.append("Merchant details").append("\n")
+                .append("name: ").append(giftCardMerchant.name).append("\n")
+                .append("id: ").append(giftCardMerchant.merchantId).append("\n")
+                .append("min: ").append(giftCardMerchant.minCardPurchase).append("\n")
+                .append("max: ").append(giftCardMerchant.maxCardPurchase).append("\n")
+                .append("discount: ").append(giftCardMerchant.savingsFraction).append("\n")
+                .append("denominations type: ").append(giftCardMerchant.denominationsType).append("\n")
+                .append("denominations: ").append(giftCardMerchant.denominations).append("\n")
+                .append("\n")
+        } else {
+            report.append("No merchant selected").append("\n")
+        }
+        report.append("\n")
+        report.append("Purchase Details").append("\n")
+        report.append("amount: ").append(giftCardPaymentValue.value.toFriendlyString()).append("\n")
+        report.append("\n")
+        ex.errorCode?.let {
+            report.append("code: ").append(it).append("\n")
+        }
+        ex.errorBody?.let {
+            report.append("body:\n").append(it).append("\n")
+        }
+        return report.toString()
+    }
 }
diff --git a/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/ctxspend/dialogs/PurchaseGiftCardConfirmDialog.kt b/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/ui/ctxspend/dialogs/PurchaseGiftCardConfirmDialog.kt
@@ -17,8 +17,10 @@
 
 package org.dash.wallet.features.exploredash.ui.ctxspend.dialogs
 
+import android.content.Intent
 import android.os.Bundle
 import android.view.View
+import androidx.activity.result.contract.ActivityResultContracts
 import androidx.annotation.StyleRes
 import androidx.constraintlayout.widget.ConstraintSet
 import androidx.core.view.isGone
@@ -64,6 +66,10 @@ class PurchaseGiftCardConfirmDialog : OffsetDialogFragment(R.layout.dialog_confi
     @Inject
     lateinit var authManager: AuthenticationManager
 
+    private val launcher = registerForActivityResult(ActivityResultContracts.StartActivityForResult()) {
+        // Optionally handle result here
+    }
+
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
@@ -101,12 +107,39 @@ class PurchaseGiftCardConfirmDialog : OffsetDialogFragment(R.layout.dialog_confi
                 viewModel.purchaseGiftCard()
             } catch (ex: CTXSpendException) {
                 hideLoading()
-                AdaptiveDialog.create(
-                    R.drawable.ic_error,
-                    getString(R.string.gift_card_purchase_failed),
-                    ex.message ?: getString(R.string.gift_card_error),
-                    getString(R.string.button_close)
-                ).show(requireActivity())
+                when {
+                    ex.errorCode == 400 && ex.isLimitError -> {
+                        AdaptiveDialog.create(
+                            R.drawable.ic_error,
+                            getString(R.string.gift_card_purchase_failed),
+                            getString(R.string.gift_card_limit_error),
+                            getString(R.string.button_close),
+                            getString(R.string.gift_card_contact_ctx)
+                        ).show(requireActivity()) { result ->
+                            if (result == true) {
+                                // TODO: share
+                                val intent = viewModel.createEmailIntent(
+                                    "CTX Issue: Spending Limit Problem",
+                                    ex
+                                )
+
+                                val chooser = Intent.createChooser(
+                                    intent,
+                                    getString(R.string.report_issue_dialog_mail_intent_chooser)
+                                )
+                                launcher.launch(chooser)
+                            }
+                        }
+                    }
+                    else -> {
+                        AdaptiveDialog.create(
+                            R.drawable.ic_error,
+                            getString(R.string.gift_card_purchase_failed),
+                            ex.message ?: getString(R.string.gift_card_error),
+                            getString(R.string.button_close)
+                        ).show(requireActivity())
+                    }
+                }
                 return@launch
             }
 
diff --git a/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/utils/CTXSpendConstants.kt b/features/exploredash/src/main/java/org/dash/wallet/features/exploredash/utils/CTXSpendConstants.kt
@@ -22,4 +22,5 @@ object CTXSpendConstants {
     @JvmField var CLIENT_ID = "dcg_android"
     const val DEFAULT_DISCOUNT: Int = 0 // 0%
     const val DEFAULT_DISCOUNT_AS_DOUBLE: Double = 0.0 // 0%
+    const val REPORT_EMAIL = "support@ctx.com"
 }
diff --git a/features/exploredash/src/main/res/values/strings-explore-dash.xml b/features/exploredash/src/main/res/values/strings-explore-dash.xml
@@ -228,6 +228,7 @@
     <string name="cancel">Cancel</string>
     <string name="gift_card_error">For some reason we were not able to buy a gift card. Please, try again.</string>
     <string name="gift_card_details_error">For some reason we were not able to buy a gift card. Please contact support.</string>
+    <string name="gift_card_limit_error">The purchase limits for this merchant have changed.  Please contact CTX Support for more information.</string>
     <string name="gift_card_unknown_error">For some reason we were not able to buy a gift card. Please contact support with the txid %s.</string>
     <string name="gift_card_rejected">The payment has been rejected.  Please contact CTX with gift card id %s and payment id %s and transaction id %s.</string>
     <string name="gift_card_redeem_url_not_supported">The payment has was made for merchant that supplies a redeem URL, but that is not currently supported.  Please contact CTX with gift card id %s and payment id %s and transaction id %s.</string>
@@ -237,6 +238,7 @@
     <string name="accept_to_proceed">To create an account at DashSpend you have to accept DashSpend terms and conditions</string>
     <string name="view_terms_conditions">Terms &amp; conditions</string>
     <string name="barcode_placeholder">As soon as your code is generated, it will be displayed here.</string>
+    <string name="gift_card_contact_ctx">Contact CTX Support</string>
 
     <!-- ctx spend login-->
     <string name="create_ctx_spend_account">Create account</string>
diff --git a/features/exploredash/src/test/java/org/dash/wallet/features/exploredash/CTXSpendExceptionTest.kt b/features/exploredash/src/test/java/org/dash/wallet/features/exploredash/CTXSpendExceptionTest.kt
@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2025. Dash Core Group.
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package org.dash.wallet.features.exploredash
+
+import org.dash.wallet.features.exploredash.repository.CTXSpendException
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertTrue
+import org.junit.Test
+
+class CTXSpendExceptionTest {
+    @Test
+    fun limitErrorTest() {
+        val errorBody = """
+            {
+              "fields": {
+                "fiatAmount": [
+                  "above threshold"
+                ],
+                "message": "Bad request"
+              }
+            }
+        """
+        val exception = CTXSpendException("response error", 400, errorBody)
+        assertEquals(400, exception.errorCode)
+        assertTrue(exception.isLimitError)
+    }
+
+    @Test
+    fun unknownErrorTest() {
+        val exception = CTXSpendException("other type of error")
+        assertEquals(null, exception.errorCode)
+        assertFalse(exception.isLimitError)
+    }
+
+    @Test
+    fun malformedJsonErrorTest() {
+        val malformedErrorBody = "{ this is not valid json }"
+        val exception = CTXSpendException("response error", 400, malformedErrorBody)
+        assertEquals(400, exception.errorCode)
+        // Verify that parsing errors don't cause the app to consider this a limit error
+        assertFalse(exception.isLimitError)
+    }
+}
diff --git a/wallet/res/values/strings.xml b/wallet/res/values/strings.xml
@@ -295,7 +295,6 @@
     <string name="report_issue_dialog_collect_installed_packages">Append list of installed packages</string>
     <string name="report_issue_dialog_collect_application_log">Append application log</string>
     <string name="report_issue_dialog_collect_wallet_dump">Append wallet dump</string>
-    <string name="report_issue_dialog_mail_intent_chooser">Send report using…</string>
     <string name="report_issue_dialog_mail_intent_failed">Sending report failed.</string>
     <string name="report_issue_dialog_generating_report">Generating report</string>
     <string name="report_transaction_history_export">Export</string>

Original file line number	Diff line number	Diff line change
`@@ -22,4 +22,5 @@ object CTXSpendConstants {`
`22`	`22`	`@JvmField var CLIENT_ID = "dcg_android"`
`23`	`23`	`const val DEFAULT_DISCOUNT: Int = 0 // 0%`
`24`	`24`	`const val DEFAULT_DISCOUNT_AS_DOUBLE: Double = 0.0 // 0%`
	`25`	`+ const val REPORT_EMAIL = "support@ctx.com"`
`25`	`26`	`}`