requester: choose one sock able to respond to the wanted request type#241
Open
joelguittet wants to merge 1 commit intodashersw:masterfrom
Open
requester: choose one sock able to respond to the wanted request type#241joelguittet wants to merge 1 commit intodashersw:masterfrom
joelguittet wants to merge 1 commit intodashersw:masterfrom
Conversation
Owner
|
Thank you for the pull request @joelguittet! respondsTo has historically been only used for the Sockend component, so this would be a breaking change. Cote has never had a breaking change before in 8 years, therefore this is not a light addition. One would need to deprecate the current use of respondsTo, and in a major version (v2) introduce this segregation. As I mentioned before, kotelett already has this dynamic message selection implemented, without the use of such a static field. I would very much love to continue this work there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requester sends the wanted request type only to a suitable responder able to provide an answer, based on advertisement content.
See issue #240
Joel