Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake version requirements #531

Open
jprotze opened this issue May 2, 2018 · 6 comments
Open

Cmake version requirements #531

jprotze opened this issue May 2, 2018 · 6 comments
Assignees
Labels

Comments

@jprotze
Copy link

jprotze commented May 2, 2018

When compiling dash with clang compiler and cmake version 2.8.12.2, the compilation results in errors like:

DASH-SRC/dash/test/meta/ConstexprTest.cc:15:19: error: constexpr variable 'acc' must be initialized by a constant expression
    constexpr int acc = dash::ce::accumulate(
                  ^     ~~~~~~~~~~~~~~~~~~~~~

After switching to a more recent cmake version (3.6.0), the error is gone.

In my opinion, the minimum required cmake version should be lifted.

@rkowalewski
Copy link

Could you please post the generated compile_commands.json with CMake 2.8 and CMake 3.6.0. I think this depends on the c++ standard which should be at least c++11.

@fmoessbauer
Copy link
Member

A minimal CI environment (cmake 2.8.12, gcc 4.8) is added in #552. As the bug does not show up there, this is a cmake unrelated issue.

@jprotze
Copy link
Author

jprotze commented May 21, 2018

compile_commands.json-3.6.0.txt
compile_commands.json-2.8.12.2.txt

cmake 3.6.0 adds -std=gnu99 and -std=gnu++14 as compiler flags

@fmoessbauer
Copy link
Member

Hi Joachim, thanks for the logs, I'm now able to reproduce the bug. Seems to be a bug in CMake, working on a fix.

@fmoessbauer fmoessbauer added bug and removed question labels May 21, 2018
@fmoessbauer fmoessbauer self-assigned this May 21, 2018
@fmoessbauer
Copy link
Member

@devreal , @rkowalewski : Is this still an issue? Do we plan to lift the CMake version?

@devreal
Copy link
Member

devreal commented Oct 15, 2018

From my point of view, we can upgrade the minimal CMake required to >=3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants