Merge pull request rails#32648 from bogdanvlviv/improve-pattern-filenames-to-catch-more-style-offences

Allow rubocop check more files

Author: rafaelfranca

.rubocop.yml

@@ -14,12 +14,12 @@ AllCops:
 # Prefer assert_not_x over refute_x
 CustomCops/RefuteNot:
   Include:
-    - '**/*_test.rb'
+    - '**/test/**/*'
 
 # Prefer assert_not over assert !
 CustomCops/AssertNot:
   Include:
-    - '**/*_test.rb'
+    - '**/test/**/*'
 
 # Prefer &&/|| over and/or.
 Style/AndOr:

activesupport/test/cache/behaviors/cache_delete_matched_behavior.rb

@@ -7,9 +7,9 @@ def test_delete_matched
     @cache.write("foo/bar", "baz")
     @cache.write("fu/baz", "bar")
     @cache.delete_matched(/oo/)
-    assert !@cache.exist?("foo")
+    assert_not @cache.exist?("foo")
     assert @cache.exist?("fu")
-    assert !@cache.exist?("foo/bar")
+    assert_not @cache.exist?("foo/bar")
     assert @cache.exist?("fu/baz")
   end
 end

activesupport/test/cache/behaviors/cache_store_behavior.rb

@@ -33,7 +33,7 @@ def test_fetch_with_cache_miss_passes_key_to_block
 
     cache_miss = false
     assert_equal 3, @cache.fetch("foo") { |key| cache_miss = true; key.length }
-    assert !cache_miss
+    assert_not cache_miss
   end
 
   def test_fetch_with_forced_cache_miss
@@ -308,7 +308,7 @@ def test_delete
     @cache.write("foo", "bar")
     assert @cache.exist?("foo")
     assert @cache.delete("foo")
-    assert !@cache.exist?("foo")
+    assert_not @cache.exist?("foo")
   end
 
   def test_original_store_objects_should_not_be_immutable

activesupport/test/cache/behaviors/cache_store_version_behavior.rb

@@ -30,7 +30,7 @@ def test_exist_with_right_version_should_be_true
 
   def test_exist_with_wrong_version_should_be_false
     @cache.write("foo", "bar", version: 1)
-    assert !@cache.exist?("foo", version: 2)
+    assert_not @cache.exist?("foo", version: 2)
   end
 
   def test_reading_and_writing_with_model_supporting_cache_version

activesupport/test/cache/behaviors/failure_safety_behavior.rb

@@ -63,7 +63,7 @@ def test_exist_failure_returns_false
     @cache.write("foo", "bar")
 
     emulating_unavailability do |cache|
-      assert !cache.exist?("foo")
+      assert_not cache.exist?("foo")
     end
   end
 

activesupport/test/file_update_checker_shared_tests.rb

@@ -30,7 +30,7 @@ def run(*args)
 
     checker = new_checker { i += 1 }
 
-    assert !checker.execute_if_updated
+    assert_not checker.execute_if_updated
     assert_equal 0, i
   end
 
@@ -41,7 +41,7 @@ def run(*args)
 
     checker = new_checker(tmpfiles) { i += 1 }
 
-    assert !checker.execute_if_updated
+    assert_not checker.execute_if_updated
     assert_equal 0, i
   end
 
@@ -212,7 +212,7 @@ def run(*args)
     touch(tmpfile("foo.rb"))
     wait
 
-    assert !checker.execute_if_updated
+    assert_not checker.execute_if_updated
     assert_equal 0, i
   end
 
@@ -238,7 +238,7 @@ def run(*args)
     mkdir(subdir)
     wait
 
-    assert !checker.execute_if_updated
+    assert_not checker.execute_if_updated
     assert_equal 0, i
 
     touch(File.join(subdir, "nested.rb"))
@@ -259,7 +259,7 @@ def run(*args)
     touch(tmpfile("new.txt"))
     wait
 
-    assert !checker.execute_if_updated
+    assert_not checker.execute_if_updated
     assert_equal 0, i
 
     # subdir does not look for Ruby files, but its parent tmpdir does.