Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu entry is non-functional right after installation #22

Open
mikini opened this issue Nov 15, 2017 · 6 comments
Open

Context menu entry is non-functional right after installation #22

mikini opened this issue Nov 15, 2017 · 6 comments

Comments

@mikini
Copy link

mikini commented Nov 15, 2017

After installation of v1.0 from AMO and enabling the contextual menu I do get the menu but nothing is happening when selecting it. The menubar icon button do work however.

I see no output on the javascript console when selecting it either.

@dascritch
Copy link
Owner

Strange, i've it working on it.
Is it working on this very same page ?
Which version of Firefox do you use (I have to confess, i've tested it on 58)

@mikini
Copy link
Author

mikini commented Nov 15, 2017

Sorry, meant to mention this was on a new installation of Firefox Quantum 57.0 (64-bit), but forgot.

However, after restarting firefox both context menu and button does work correctly.

I now see this error on the console;

Clippings/wx::content.js: Initializing content script for:
https://github.com/dascritch/anchors-reveal/issues/22#issuecomment-344570852
content.js:229:3
Document body element: [object HTMLBodyElement] (DOM nodeName=BODY)
content.js:230:3
Failed to find container
anchors-reveal.js:115:12

@mikini mikini changed the title Context menu entry is non-functional Context menu entry is non-functional right after installation Nov 15, 2017
@dascritch
Copy link
Owner

Aouch, I have to do a special test-case about it.
Thanks a lot for so much precisions. Alas, i won't be able to correct my addon this week

@mikini
Copy link
Author

mikini commented Nov 15, 2017

No problem, thanks for creating this and releasing as GPL ;).

Note: Also, I'm on Ubuntu 16.04.

@dascritch
Copy link
Owner

Well, I now do remember : the new entry of a menu will only appear/disappear on new tabs, once this pref is changed. I think I will have to play with signals to change that.
Will be a little bit harder

@dascritch
Copy link
Owner

Hello @mikini , can you retest, please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants