Review: Weight for Extrinsics

[hackfisher]

[clearloop]

Transaction Weight

A number of resources in any chain can be limited, such as storage or computation. Weights exist to prevent individual components of the chain from consuming too much of any resource.

Consuming some weights should generally incur a fee. The fee implications of the weight system are covered in the Fee Developer document.

Weight in current Darwinia

• Transaction
  • RING and KTON balances
  • Treasury
• Nomination
  • Nomination in staking
• Voting
  • Voting in elections-phragmen

References

• Transaction Weight (substrate doc)
• Weight system in substrate (substrate doc)
• Calculate weight in substrate (ZH substrate guide)
• estimate_fee in web3 (web3 doc)
• Transaction fee estimation (substrate issue)

[clearloop]

If it is necessary for creating a new pallet named weights to manage weight?

Here are two simple benefits:

• Gather weight calculations into one crate
• Easy to write benchmark about weight

Weights in darwinia

Before the above, my first step is to list a table contains all weights' designs in darwinia.

• weight list

[hackfisher]

Common used weight:

10000
50000
100000
150000
200000
500000
750000
1000000
2000000

[clearloop]

Common used weight:

10000
50000
100000
150000
200000
500000
750000
1000000
2000000

I'll take this issue tonight, in view of the lesson from #331, I might separate this issue into serval prs, each of them will relate some docs.

• migrate all weight methods from substrate
• correct weight costs follow above
• update weight attributes for darwinia style methods(doc required)
  • update the-darwinia-book parallel with this step
• maybe do some benchmark for weights
• more steps depending on the transaction-payment pallet's plan.

Pallets

• balances Add benchmark for balances #342
• chainrelay
  • relay Review all weights #354
  • baking Review all weights #354
• elections-phragmen Review all weights #354
• staking Review all weights #354
• treasury Review all weights #354