Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: darvaza-proxy/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.18.3
Choose a base ref
...
head repository: darvaza-proxy/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.18.4
Choose a head ref
  • 7 commits
  • 7 files changed
  • 2 contributors

Commits on Oct 14, 2025

  1. Configuration menu
    Copy the full SHA
    8f5bd7b View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2025

  1. Merge pull request #146 (deps)

    chore(deps): update actions/setup-node action to v6
    amery authored Oct 15, 2025
    Configuration menu
    Copy the full SHA
    2e6c49d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2025

  1. refactor(testing): make error assertions independent with domain-spec…

    …ific messaging
    
    Convert AssertError and AssertNoError from derived functions that delegate to
    nil assertions into independent base functions with error-specific messaging.
    
    Changes:
    - AssertError now directly checks err != nil and produces "expected error, got nil".
    - AssertNoError now directly checks err == nil and produces "unexpected error: %v".
    - Both functions log domain-appropriate success messages.
    - Update TESTING_core.md to reflect the new architecture hierarchy.
    - Maintain 100% test coverage and all existing tests pass.
    
    This improves clarity when debugging test failures by providing error-oriented
    messages rather than generic nil-checking messages.
    
    Signed-off-by: Alejandro Mery <amery@apptly.co>
    amery committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    0e82405 View commit details
    Browse the repository at this point in the history
  2. feat(testing): add AssertNotContain and AssertMustNotContain assertions

    Add negative variants of string containment assertions to complement the
    existing AssertContains functionality.
    
    Implementation:
    - Add AssertNotContain to verify substring absence.
    - Add AssertMustNotContain for fatal variant that calls FailNow.
    - Both functions follow established patterns with appropriate error messages.
    - Use "NotContain" (not "NotContains") for grammatical consistency.
    
    Testing:
    - Add comprehensive unit test for AssertNotContain.
    - Add integration test for AssertMustNotContain with MockT.
    - Achieve 100% test coverage for both new functions.
    - Overall package coverage improved to 97.4%.
    
    Documentation:
    - Update TESTING_core.md function hierarchy.
    - Add examples to TESTING.md Advanced Assertions.
    - Update README.md with new assertions in both basic and fatal lists.
    - All documentation maintains consistent formatting and passes linting.
    
    The implementation provides clear error messages:
    - Success: "does not contain %q".
    - Failure: "expected %q not to contain %q".
    
    Signed-off-by: Alejandro Mery <amery@apptly.co>
    amery committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    cb30c57 View commit details
    Browse the repository at this point in the history
  3. docs: fix API documentation inaccuracies

    This commit addresses multiple documentation issues identified during API
    verification, ensuring all function signatures and descriptions accurately
    reflect the actual implementation.
    
    Key fixes:
    - Fix AddrPort function signature from AddrPort(addr, port) to AddrPort(v)
      and correct description to reflect extraction rather than creation.
    - Correct Zero function signature from Zero[T]() to Zero[T](_ *T) to show
      the required dummy parameter for type inference.
    - Update all assertion function signatures to use 'name...' instead of
      'msg...' to accurately reflect actual parameter names (affects 25+
      functions including AssertEqual, AssertTrue, AssertMust* variants).
    - Fix IsError function signatures by removing incorrect generic type
      parameters [T] and updating parameter lists to match implementation.
    
    The documentation now provides 100% accurate function signatures that
    match the actual Go implementation, improving developer experience and
    reducing confusion when using the API.
    
    Signed-off-by: Alejandro Mery <amery@apptly.co>
    amery committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    7dfc11b View commit details
    Browse the repository at this point in the history
  4. docs: rename AGENT.md to AGENTS.md and update references

    Rename AGENT.md to AGENTS.md as AGENTS.md is now the standard.
    Update all internal references within the renamed file and
    cross-references in README.md to maintain documentation integrity.
    
    Signed-off-by: Alejandro Mery <amery@apptly.co>
    amery committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    cf593fd View commit details
    Browse the repository at this point in the history
  5. Merge pull request #145 (testing)

    Testing Infrastructure Enhancement and Documentation Overhaul
    amery authored Oct 27, 2025
    Configuration menu
    Copy the full SHA
    9e3b9f0 View commit details
    Browse the repository at this point in the history
Loading