-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: darvaza-proxy/core
base: v0.18.3
head repository: darvaza-proxy/core
compare: v0.18.4
- 7 commits
- 7 files changed
- 2 contributors
Commits on Oct 14, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 8f5bd7b - Browse repository at this point
Copy the full SHA 8f5bd7bView commit details
Commits on Oct 15, 2025
-
Merge pull request #146 (deps)
chore(deps): update actions/setup-node action to v6
Configuration menu - View commit details
-
Copy full SHA for 2e6c49d - Browse repository at this point
Copy the full SHA 2e6c49dView commit details
Commits on Oct 27, 2025
-
refactor(testing): make error assertions independent with domain-spec…
…ific messaging Convert AssertError and AssertNoError from derived functions that delegate to nil assertions into independent base functions with error-specific messaging. Changes: - AssertError now directly checks err != nil and produces "expected error, got nil". - AssertNoError now directly checks err == nil and produces "unexpected error: %v". - Both functions log domain-appropriate success messages. - Update TESTING_core.md to reflect the new architecture hierarchy. - Maintain 100% test coverage and all existing tests pass. This improves clarity when debugging test failures by providing error-oriented messages rather than generic nil-checking messages. Signed-off-by: Alejandro Mery <amery@apptly.co>
Configuration menu - View commit details
-
Copy full SHA for 0e82405 - Browse repository at this point
Copy the full SHA 0e82405View commit details -
feat(testing): add AssertNotContain and AssertMustNotContain assertions
Add negative variants of string containment assertions to complement the existing AssertContains functionality. Implementation: - Add AssertNotContain to verify substring absence. - Add AssertMustNotContain for fatal variant that calls FailNow. - Both functions follow established patterns with appropriate error messages. - Use "NotContain" (not "NotContains") for grammatical consistency. Testing: - Add comprehensive unit test for AssertNotContain. - Add integration test for AssertMustNotContain with MockT. - Achieve 100% test coverage for both new functions. - Overall package coverage improved to 97.4%. Documentation: - Update TESTING_core.md function hierarchy. - Add examples to TESTING.md Advanced Assertions. - Update README.md with new assertions in both basic and fatal lists. - All documentation maintains consistent formatting and passes linting. The implementation provides clear error messages: - Success: "does not contain %q". - Failure: "expected %q not to contain %q". Signed-off-by: Alejandro Mery <amery@apptly.co>
Configuration menu - View commit details
-
Copy full SHA for cb30c57 - Browse repository at this point
Copy the full SHA cb30c57View commit details -
docs: fix API documentation inaccuracies
This commit addresses multiple documentation issues identified during API verification, ensuring all function signatures and descriptions accurately reflect the actual implementation. Key fixes: - Fix AddrPort function signature from AddrPort(addr, port) to AddrPort(v) and correct description to reflect extraction rather than creation. - Correct Zero function signature from Zero[T]() to Zero[T](_ *T) to show the required dummy parameter for type inference. - Update all assertion function signatures to use 'name...' instead of 'msg...' to accurately reflect actual parameter names (affects 25+ functions including AssertEqual, AssertTrue, AssertMust* variants). - Fix IsError function signatures by removing incorrect generic type parameters [T] and updating parameter lists to match implementation. The documentation now provides 100% accurate function signatures that match the actual Go implementation, improving developer experience and reducing confusion when using the API. Signed-off-by: Alejandro Mery <amery@apptly.co>
Configuration menu - View commit details
-
Copy full SHA for 7dfc11b - Browse repository at this point
Copy the full SHA 7dfc11bView commit details -
docs: rename AGENT.md to AGENTS.md and update references
Rename AGENT.md to AGENTS.md as AGENTS.md is now the standard. Update all internal references within the renamed file and cross-references in README.md to maintain documentation integrity. Signed-off-by: Alejandro Mery <amery@apptly.co>
Configuration menu - View commit details
-
Copy full SHA for cf593fd - Browse repository at this point
Copy the full SHA cf593fdView commit details -
Merge pull request #145 (testing)
Testing Infrastructure Enhancement and Documentation Overhaul
Configuration menu - View commit details
-
Copy full SHA for 9e3b9f0 - Browse repository at this point
Copy the full SHA 9e3b9f0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.18.3...v0.18.4