Skip to content

Commit 3f0d9a0

Browse files
authored
refactor: rename JsonCacheSecStorage to JsonCacheFlutterSecureStorage (#129)
1 parent 37053de commit 3f0d9a0

5 files changed

+40
-35
lines changed

CHANGELOG.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111

1212
- fix comment in JsonCacheHive class constructor — [120](https://github.com/dartoos-dev/json_cache/issues/120).
1313

14+
- rename class JsonCacheSecStorage to JsonCacheFlutterSecureStorage — **BREAKING CHANGE**[126](https://github.com/dartoos-dev/json_cache/issues/126).
15+
1416
### Removed
1517

16-
- drop support for the 'EncryptedSharedPreferences' package — **BREAKING CHANGE**[125](https://github.com/dartoos-dev/json_cache/issues/125).
18+
- support for the 'EncryptedSharedPreferences' package — **BREAKING CHANGE**[125](https://github.com/dartoos-dev/json_cache/issues/125).
1719

1820
## [1.5.2] - 2023-02-28
1921

README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Rultor.com](https://www.rultor.com/b/dartoos-dev/json_cache)](https://www.rultor
3030
- [JsonCacheTry — Enhanced Diagnostic Messages](#jsoncachetry)
3131
- [JsonCachePrefs — SharedPreferences](#jsoncacheprefs)
3232
- [JsonCacheLocalStorage — LocalStorage](#jsoncachelocalstorage)
33-
- [JsonCacheSecStorage — FlutterSecureStorage](#jsoncachesecstorage)
33+
- [JsonCacheFlutterSecureStorage — FlutterSecureStorage](#jsoncachefluttersecurestorage)
3434
- [JsonCacheCrossLocalStorage — CrossLocalStorage](#jsoncachecrosslocalstorage)
3535
- [JsonCacheHive — Hive](#jsoncachehive)
3636
- [Unit Test Tips](#unit-test-tips)
@@ -286,16 +286,16 @@ is an implementation on top of the
286286
```
287287

288288

289-
### JsonCacheSecStorage
289+
### JsonCacheFlutterSecureStorage
290290

291-
JsonCacheSecStorage
291+
JsonCacheFlutterSecureStorage
292292
is an implementation on top of the
293293
[flutter_secure_storage](https://pub.dev/packages/flutter_secure_storage) package.
294294

295295
```dart
296296
297-
final secStorage = FlutterSecureStorage(…);
298-
final JsonCache jsonCache = JsonCacheSecStorage(secStorage);
297+
final flutterSecureStorage = FlutterSecureStorage(…);
298+
final JsonCache jsonCache = JsonCacheFlutterSecureStorage(flutterSecureStorage);
299299
// In order to write a string value, define it as a map key whose associated
300300
// value is a boolean placeholder value set to 'true'.
301301
jsonCache.refresh('secret', {'a secret info': true});

lib/json_cache.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ export 'src/json_cache.dart';
55
export 'src/json_cache_cross_local_storage.dart';
66
export 'src/json_cache_exception.dart';
77
export 'src/json_cache_fake.dart';
8+
export 'src/json_cache_flutter_secure_storage.dart';
89
export 'src/json_cache_hive.dart';
910
export 'src/json_cache_hollow.dart';
1011
export 'src/json_cache_local_storage.dart';
1112
export 'src/json_cache_mem.dart';
1213
export 'src/json_cache_prefs.dart';
13-
export 'src/json_cache_sec_storage.dart';
1414
export 'src/json_cache_try.dart';
1515
export 'src/json_cache_wrap.dart';

lib/src/json_cache_sec_storage.dart renamed to lib/src/json_cache_flutter_secure_storage.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ import 'package:json_cache/json_cache.dart';
77
///
88
/// See also:
99
/// - [flutter_secure_storage](https://pub.dev/packages/flutter_secure_storage).
10-
class JsonCacheSecStorage implements JsonCache {
10+
class JsonCacheFlutterSecureStorage implements JsonCache {
1111
/// Sets the [FlutterSecureStorage] instance.
12-
const JsonCacheSecStorage(this._storage);
12+
const JsonCacheFlutterSecureStorage(this._storage);
1313

14-
// the encapsulated [FlutterSecureStorage] instance.
14+
// The encapsulated [FlutterSecureStorage] instance.
1515
final FlutterSecureStorage _storage;
1616

1717
@override

test/json_cache_sec_storage_test.dart renamed to test/json_cache_flutter_secure_storage_test.dart

+28-25
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,24 @@ import 'package:json_cache/json_cache.dart';
44
import 'flutter_secure_storage_mock.dart';
55

66
void main() {
7-
group('JsonCacheSecStorage', () {
7+
group('JsonCacheFlutterSecureStorage', () {
88
test('clear, value, refresh', () async {
99
final secStorageMock = FlutterSecureStorageMock();
10-
final JsonCacheSecStorage secCache = JsonCacheSecStorage(secStorageMock);
10+
final JsonCacheFlutterSecureStorage flutterSecureCache =
11+
JsonCacheFlutterSecureStorage(secStorageMock);
1112
const profKey = 'profile';
1213
const profData = <String, Object>{'id': 1, 'name': 'John Due'};
13-
await secCache.refresh(profKey, profData);
14+
await flutterSecureCache.refresh(profKey, profData);
1415
expect(secStorageMock.writeInvokations, 1);
1516

16-
var prof = await secCache.value(profKey);
17+
var prof = await flutterSecureCache.value(profKey);
1718
expect(prof, profData);
1819
expect(secStorageMock.readInvokations, 1);
1920

20-
await secCache.clear();
21+
await flutterSecureCache.clear();
2122
expect(secStorageMock.deleteAllInvokations, 1);
2223

23-
prof = await secCache.value(profKey);
24+
prof = await flutterSecureCache.value(profKey);
2425
expect(prof, isNull);
2526
expect(secStorageMock.readInvokations, 2);
2627
});
@@ -34,52 +35,54 @@ void main() {
3435
'notifications': {'enabled': true}
3536
};
3637
final secStorageMock = FlutterSecureStorageMock();
37-
final JsonCacheSecStorage secCache = JsonCacheSecStorage(secStorageMock);
38+
final JsonCacheFlutterSecureStorage flutterSecureCache =
39+
JsonCacheFlutterSecureStorage(secStorageMock);
3840
// update data
39-
await secCache.refresh(profKey, profData);
40-
await secCache.refresh(prefKey, prefData);
41+
await flutterSecureCache.refresh(profKey, profData);
42+
await flutterSecureCache.refresh(prefKey, prefData);
4143

4244
// test for `true`
43-
expect(await secCache.contains(profKey), true);
44-
expect(await secCache.contains(prefKey), true);
45+
expect(await flutterSecureCache.contains(profKey), true);
46+
expect(await flutterSecureCache.contains(prefKey), true);
4547

4648
// test for `false`
47-
expect(await secCache.contains('a key'), false);
48-
await secCache.remove(profKey);
49-
expect(await secCache.contains(profKey), false);
50-
await secCache.remove(prefKey);
51-
expect(await secCache.contains(prefKey), false);
49+
expect(await flutterSecureCache.contains('a key'), false);
50+
await flutterSecureCache.remove(profKey);
51+
expect(await flutterSecureCache.contains(profKey), false);
52+
await flutterSecureCache.remove(prefKey);
53+
expect(await flutterSecureCache.contains(prefKey), false);
5254
});
5355
test('remove', () async {
5456
final secStorageMock = FlutterSecureStorageMock();
55-
final JsonCacheSecStorage secCache = JsonCacheSecStorage(secStorageMock);
57+
final JsonCacheFlutterSecureStorage flutterSecureCache =
58+
JsonCacheFlutterSecureStorage(secStorageMock);
5659
const profKey = 'profile';
5760
const prefKey = 'preferences';
5861
final profData = <String, Object>{'id': 1, 'name': 'John Due'};
5962
final prefData = <String, Object>{
6063
'theme': 'dark',
6164
'notifications': {'enabled': true}
6265
};
63-
await secCache.refresh(profKey, profData);
64-
await secCache.refresh(prefKey, prefData);
66+
await flutterSecureCache.refresh(profKey, profData);
67+
await flutterSecureCache.refresh(prefKey, prefData);
6568
expect(secStorageMock.writeInvokations, 2);
6669

67-
var prof = await secCache.value(profKey);
70+
var prof = await flutterSecureCache.value(profKey);
6871
expect(prof, profData);
6972
expect(secStorageMock.readInvokations, 1);
7073

71-
await secCache.remove(profKey);
74+
await flutterSecureCache.remove(profKey);
7275
expect(secStorageMock.deleteInvokations, 1);
73-
prof = await secCache.value(profKey);
76+
prof = await flutterSecureCache.value(profKey);
7477
expect(prof, isNull);
7578
expect(secStorageMock.readInvokations, 2);
7679

77-
var pref = await secCache.value(prefKey);
80+
var pref = await flutterSecureCache.value(prefKey);
7881
expect(pref, prefData);
7982
expect(secStorageMock.readInvokations, 3);
80-
await secCache.remove(prefKey);
83+
await flutterSecureCache.remove(prefKey);
8184
expect(secStorageMock.deleteInvokations, 2);
82-
pref = await secCache.value(prefKey);
85+
pref = await flutterSecureCache.value(prefKey);
8386
expect(pref, isNull);
8487
expect(secStorageMock.readInvokations, 4);
8588
});

0 commit comments

Comments
 (0)