Robust reuse of Chrome profiles #341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
added a commit
to kenzieschmoll/browser_launcher
that referenced
this pull request
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Chrome process was started with a reused Chrome profile and used a current running instance, our expectations of outputs was incorrect. The modified logic now robustly determines the debug port.
This should close: #319
Note this issue was not caught because our Chrome tests only run on Linux. By default, killing the Chrome process on Linux does not keep the background process around so the instance can not be reused. This behavior is different on Mac and the corresponding Chrome tests were actually failing.