-
Notifications
You must be signed in to change notification settings - Fork 83
Handle page refreshes and opening in new tabs #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ances, and handle additional edge cases
Discussed offline. This does not handle the |
/// [appId] is a unique String embedded in the application available through | ||
/// `window.$dartAppId`. | ||
/// [appInstanceId] is a unique String embedded in the instance of the | ||
/// application available through `window.$dartAppInstanceId`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment that an instance in this case is one to one with a tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It changes if there is a refresh in the same tab though - it unique per instance of the app.
Fixes #202
Note that I added an app instance id - this allows us to unambiguously identify the correct tab for a given instance of an app, separate from the app id which is consistent across all instances.
We cache the debug services per app ID and keep them running, but we only allow debugging one instance of a given app at a time.
The rough logic here is as follows: