Add test timeout of 2 minutes for all tests missing a timeout #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderDake
approved these changes
Dec 22, 2022
| @@ -9,6 +9,7 @@ | |||
| @OnPlatform({ | |||
| 'windows': Skip('https://github.com/dart-lang/webdev/issues/711'), | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
Is this blank line meant to be a timeout?
There was a problem hiding this comment.
No it's not, just formatting! There is a timeout set for this file already
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1845: "All tests should have a timeout set"
Work towards #1846: "Long running tests should be moved to a cron job" (the
reload_testis flaky, often timing out after 5 minutes. Instead of upping the timeout, we should move it to a cron job)