Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test checking for DEBUGGER_READY and DEVTOOLS_LOAD events failing #2394

Open
elliette opened this issue Mar 25, 2024 · 2 comments
Open

Test checking for DEBUGGER_READY and DEVTOOLS_LOAD events failing #2394

elliette opened this issue Mar 25, 2024 · 2 comments
Assignees
Labels
P3 A lower priority bug or feature request package:dwds triaged

Comments

@elliette
Copy link
Contributor

In #2388 we switched to connecting to DDS instead of directly to the VMService so that DDS can handle the service extensions.

However, the test checking that the DEBUGGER_READY and DEVTOOLS_LOAD events are sent when DevTools is opened has begun failing. When I launch DevTools to do manually testing, I do see the service extension ext.dwds.sendEvent is correctly being called, and these events are being emitted, so I don't think this is a regression with the feature.

Need to follow-up to figure out what changes are required to get the test to pass again.

@bkonyi
Copy link
Collaborator

bkonyi commented Aug 7, 2024

Marking as P3 since there's no obvious issues in production, only this test failure.

@bkonyi bkonyi added P3 A lower priority bug or feature request triaged labels Aug 7, 2024
@jyameo jyameo self-assigned this Sep 30, 2024
@jyameo
Copy link
Contributor

jyameo commented Sep 30, 2024

Error log:
Screenshot 2024-09-30 at 2 48 52 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request package:dwds triaged
Projects
None yet
Development

No branches or pull requests

3 participants