Skip to content

Commit c77fd15

Browse files
committed
Correctly parse and pass on arguments to serve
Fixes mistake in b3f4355
1 parent 7e6a68b commit c77fd15

File tree

2 files changed

+27
-7
lines changed

2 files changed

+27
-7
lines changed

webdev/lib/src/command/command_base.dart

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,8 @@ abstract class CommandBase extends Command<int> {
4545
help: 'Enables verbose logging.');
4646
}
4747

48-
Future<int> runCore(String command) async {
49-
await checkPubspecLock();
50-
51-
var buildRunnerScript = await _buildRunnerScript();
52-
53-
final arguments = [command];
54-
48+
List<String> getArgs() {
49+
var arguments = <String>[];
5550
if ((argResults[_release] as bool) ?? releaseDefault) {
5651
arguments.add('--$_release');
5752
}
@@ -64,6 +59,15 @@ abstract class CommandBase extends Command<int> {
6459
if (argResults[_verbose] as bool) {
6560
arguments.add('--$_verbose');
6661
}
62+
return arguments;
63+
}
64+
65+
Future<int> runCore(String command) async {
66+
await checkPubspecLock();
67+
68+
var buildRunnerScript = await _buildRunnerScript();
69+
70+
final arguments = [command]..addAll(getArgs());
6771

6872
var exitCode = 0;
6973

webdev/lib/src/command/serve_command.dart

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,22 @@ class ServeCommand extends CommandBase {
3030
help: 'Enables logging for each request to the server.');
3131
}
3232

33+
@override
34+
List<String> getArgs() {
35+
var arguments = super.getArgs();
36+
37+
var hostname = argResults['hostname'] as String;
38+
if (hostname != null) {
39+
arguments.addAll(['--hostname', hostname]);
40+
}
41+
42+
if (argResults['log-requests'] == true) {
43+
arguments.add('--log-requests');
44+
}
45+
46+
return arguments;
47+
}
48+
3349
@override
3450
Future<int> run() => runCore('serve');
3551
}

0 commit comments

Comments
 (0)