Only check build_web_compilers dependency for 'serve' command

Author: kevmoo

webdev/CHANGELOG.md

@@ -2,7 +2,7 @@
 
 - Require and use features from `build_runner` 0.8.2.
   - Added a `--[no]-release` flag.
-- Require `build_web_compliers` 0.3.6.
+- Require `build_web_compliers` 0.3.6 when running `serve`.
   - Unless the `--no-require-build-web-compilers` flag is provided.
 
 ## 0.1.3+1

webdev/README.md

@@ -28,13 +28,12 @@ Usage: webdev serve [arguments] [<directory>[:<port>]]...
 -r, --[no-]release                        Build with release mode defaults for builders.
 -o, --output                              A directory to write the result of a build to. Or a mapping from a top-level directory in the package to the directory to write a filtered build output to. For example "web:deploy".
 -v, --verbose                             Enables verbose logging.
-    --[no-]require-build-web-compilers    If a dependency on `build_web_compilers` is required to run.
-                                          (defaults to on)
-
     --hostname                            Specify the hostname to serve on
                                           (defaults to "localhost")
 
     --log-requests                        Enables logging for each request to the server.
+    --[no-]require-build-web-compilers    If a dependency on `build_web_compilers` is required to run.
+                                          (defaults to on)
 
 Run "webdev help" to see global options.
 ```
@@ -46,14 +45,12 @@ $ webdev help build
 Run builders to build a package.
 
 Usage: webdev build [arguments]
--h, --help                                Print this usage information.
--r, --[no-]release                        Build with release mode defaults for builders.
-                                          (defaults to on)
+-h, --help            Print this usage information.
+-r, --[no-]release    Build with release mode defaults for builders.
+                      (defaults to on)
 
--o, --output                              A directory to write the result of a build to. Or a mapping from a top-level directory in the package to the directory to write a filtered build output to. For example "web:deploy".
--v, --verbose                             Enables verbose logging.
-    --[no-]require-build-web-compilers    If a dependency on `build_web_compilers` is required to run.
-                                          (defaults to on)
+-o, --output          A directory to write the result of a build to. Or a mapping from a top-level directory in the package to the directory to write a filtered build output to. For example "web:deploy".
+-v, --verbose         Enables verbose logging.
 
 Run "webdev help" to see global options.
 ```

webdev/lib/src/command/build_command.dart

@@ -16,5 +16,5 @@ class BuildCommand extends CommandBase {
   final description = 'Run builders to build a package.';
 
   @override
-  Future<int> run() => runCore('build');
+  Future<int> run() => runCore('build', requireBuildWebCompilers: false);
 }

webdev/lib/src/command/command_base.dart

@@ -16,7 +16,6 @@ const _packagesFileName = '.packages';
 const _release = 'release';
 const _output = 'output';
 const _verbose = 'verbose';
-const _requireBuildWebCompilers = 'require-build-web-compilers';
 
 /// Extend to get a command with the arguments common to all build_runner
 /// commands.
@@ -43,11 +42,7 @@ abstract class CommandBase extends Command<int> {
           abbr: 'v',
           defaultsTo: false,
           negatable: false,
-          help: 'Enables verbose logging.')
-      ..addFlag(_requireBuildWebCompilers,
-          defaultsTo: true,
-          negatable: true,
-          help: 'If a dependency on `build_web_compilers` is required to run.');
+          help: 'Enables verbose logging.');
   }
 
   List<String> getArgs() {
@@ -67,10 +62,9 @@ abstract class CommandBase extends Command<int> {
     return arguments;
   }
 
-  Future<int> runCore(String command) async {
-    await checkPubspecLock(
-        requireBuildWebCompilers:
-            argResults[_requireBuildWebCompilers] as bool);
+  Future<int> runCore(String command,
+      {@required bool requireBuildWebCompilers}) async {
+    await checkPubspecLock(requireBuildWebCompilers: requireBuildWebCompilers);
 
     var buildRunnerScript = await _buildRunnerScript();
 

webdev/lib/src/command/serve_command.dart

@@ -6,6 +6,8 @@ import 'dart:async';
 
 import 'command_base.dart';
 
+const _requireBuildWebCompilers = 'require-build-web-compilers';
+
 /// Command to execute pub run build_runner serve.
 class ServeCommand extends CommandBase {
   @override
@@ -27,7 +29,11 @@ class ServeCommand extends CommandBase {
       ..addFlag('log-requests',
           defaultsTo: false,
           negatable: false,
-          help: 'Enables logging for each request to the server.');
+          help: 'Enables logging for each request to the server.')
+      ..addFlag(_requireBuildWebCompilers,
+          defaultsTo: true,
+          negatable: true,
+          help: 'If a dependency on `build_web_compilers` is required to run.');
   }
 
   @override
@@ -47,5 +53,6 @@ class ServeCommand extends CommandBase {
   }
 
   @override
-  Future<int> run() => runCore('serve');
+  Future<int> run() => runCore('serve',
+      requireBuildWebCompilers: argResults[_requireBuildWebCompilers] as bool);
 }

webdev/test/integration_test.dart

@@ -28,7 +28,7 @@ void main() {
     'build_web_compilers': ['0.3.5', '0.4.0']
   };
 
-  group('missing dependency', () {
+  group('missing dependency on', () {
     test('`build_runner` should fail', () async {
       await d.file('pubspec.yaml', '''
 name: sample
@@ -60,7 +60,7 @@ name: sample
       await d.file('.packages', '''
 ''').create();
 
-      var process = await runWebDev(['build'], workingDirectory: d.sandbox);
+      var process = await runWebDev(['serve'], workingDirectory: d.sandbox);
 
       await _checkProcessStdout(process, [
         r'''webdev could not run for this project.
@@ -84,7 +84,7 @@ name: sample
 ''').create();
 
       var process = await runWebDev(
-          ['build', '--no-require-build-web-compilers'],
+          ['serve', '--no-require-build-web-compilers'],
           workingDirectory: d.sandbox);
 
       // Fails w/ an isolate exception instead - since this is a fake package
@@ -95,6 +95,30 @@ name: sample
       ]);
       await process.shouldExit(70);
     });
+
+    test('`build_web_compilers` should be ignored when running `build` command',
+        () async {
+      await d.file('pubspec.yaml', '''
+name: sample
+''').create();
+
+      await d
+          .file('pubspec.lock', _pubspecLock(webCompilersVersion: null))
+          .create();
+
+      await d.file('.packages', '''
+''').create();
+
+      var process = await runWebDev(['build'], workingDirectory: d.sandbox);
+
+      // Fails w/ an isolate exception instead - since this is a fake package
+      await _checkProcessStdout(process, [
+        'webdev failed with an unexpected exception.',
+        // The isolate will fail - broken .packages file
+        'Unable to spawn isolate'
+      ]);
+      await process.shouldExit(70);
+    });
   });
 
   for (var entry in invalidRanges.entries) {
@@ -129,7 +153,7 @@ name: sample
           await d.file('.packages', '''
 ''').create();
 
-          var process = await runWebDev(['build'], workingDirectory: d.sandbox);
+          var process = await runWebDev(['serve'], workingDirectory: d.sandbox);
 
           await _checkProcessStdout(process, [
             'webdev could not run for this project.',