-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow client to specify how to find the package config (#2199)
- Loading branch information
Showing
17 changed files
with
160 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
@TestOn('vm') | ||
@Timeout(Duration(minutes: 1)) | ||
|
||
import 'package:dwds/asset_reader.dart'; | ||
import 'package:path/path.dart' as p; | ||
import 'package:test/test.dart'; | ||
import 'package:test_common/test_sdk_configuration.dart'; | ||
|
||
import 'fixtures/context.dart'; | ||
import 'fixtures/fakes.dart'; | ||
import 'fixtures/project.dart'; | ||
|
||
class LoadStrategyCustomPackageConfig extends FakeStrategy { | ||
LoadStrategyCustomPackageConfig( | ||
AssetReader assetReader, | ||
) : super(assetReader); | ||
|
||
@override | ||
String? packageConfigLocator(String entrypoint) => | ||
'$entrypoint/custom/package_config/path'; | ||
} | ||
|
||
void main() { | ||
final provider = TestSdkConfigurationProvider(); | ||
tearDownAll(provider.dispose); | ||
|
||
final context = TestContext(TestProject.testWithSoundNullSafety, provider); | ||
|
||
setUpAll(() async { | ||
await context.setUp(); | ||
}); | ||
|
||
tearDownAll(() async { | ||
await context.tearDown(); | ||
}); | ||
|
||
group('Load Strategy', () { | ||
group( | ||
'When the packageConfigLocator does not specify a package config path', | ||
() { | ||
final strategy = FakeStrategy(FakeAssetReader()); | ||
|
||
test('defaults to "./dart_tool/packageconfig.json"', () { | ||
strategy.trackEntrypoint('my_app/entrypoint'); | ||
expect( | ||
p.split(strategy.packageConfigPath).join('/'), | ||
endsWith('_testSound/.dart_tool/package_config.json'), | ||
); | ||
}); | ||
}); | ||
|
||
group('When the packageConfigLocator specifies a package config path', () { | ||
final strategy = LoadStrategyCustomPackageConfig(FakeAssetReader()); | ||
|
||
test('uses the specified package config path', () { | ||
strategy.trackEntrypoint('my_app/entrypoint'); | ||
expect( | ||
strategy.packageConfigPath, | ||
equals('my_app/entrypoint/custom/package_config/path'), | ||
); | ||
}); | ||
}); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters