Rename copied SDK directory prefix from 'sdk copy' to 'sdk_copy' (#2557)

bkonyi · web-flow · commit 7dc5c3a9d0e1 · 2025-01-09T10:41:09.000-05:00
webdev/test/e2e_test.dart was failing due to paths with spaces not being handled correctly. Related issue: #2556 Fixes dart-lang/sdk#59784
diff --git a/test_common/lib/test_sdk_configuration.dart b/test_common/lib/test_sdk_configuration.dart
@@ -35,7 +35,7 @@ class TestSdkConfigurationProvider extends SdkConfigurationProvider {
     bool verbose = false,
     this.ddcModuleFormat = ModuleFormat.amd,
   }) : _verbose = verbose {
-    _sdkDirectory = Directory.systemTemp.createTempSync('sdk copy');
+    _sdkDirectory = Directory.systemTemp.createTempSync('sdk_copy');
     sdkLayout = TestSdkLayout.createDefault(_sdkDirectory.path);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ class TestSdkConfigurationProvider extends SdkConfigurationProvider {`
`35`	`35`	`bool verbose = false,`
`36`	`36`	`this.ddcModuleFormat = ModuleFormat.amd,`
`37`	`37`	`}) : _verbose = verbose {`
`38`		`- _sdkDirectory = Directory.systemTemp.createTempSync('sdk copy');`
	`38`	`+ _sdkDirectory = Directory.systemTemp.createTempSync('sdk_copy');`
`39`	`39`	`sdkLayout = TestSdkLayout.createDefault(_sdkDirectory.path);`
`40`	`40`	`}`
`41`	`41`