Skip to content

Commit 443f820

Browse files
author
Anna Gringauze
authored
Re-enable skipped reload test (#1958)
* Validate only needed summaries in expression_compiler_service * Re-enable reload test skipped due to sound null safety by default * Remove solo
1 parent a7bc3fc commit 443f820

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

dwds/test/reload_test.dart

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,13 @@ void main() {
227227
var isolate = await client.getIsolate(isolateId);
228228
var library = isolate.rootLib!.uri!;
229229

230+
final String callback =
231+
'(_, __) async => ServiceExtensionResponse.result("")';
232+
230233
await client.evaluate(
231234
isolateId,
232235
library,
233-
"registerExtension('ext.foo', (method, params) {})",
236+
"registerExtension('ext.foo', $callback)",
234237
);
235238

236239
expect(await client.callServiceExtension('hotRestart'),
@@ -244,17 +247,15 @@ void main() {
244247
await client.evaluate(
245248
isolateId,
246249
library,
247-
"registerExtension('ext.bar', (method, params) {})",
250+
"registerExtension('ext.bar', $callback)",
248251
);
249252

250253
await eventsDone;
251254

252255
final source = await context.webDriver.pageSource;
253256
// Main is re-invoked which shouldn't clear the state.
254257
expect(source, contains('Hello World!'));
255-
// TODO(https://github.com/dart-lang/webdev/issues/1818): Re-enable. The
256-
// callback passed to registerExtension requires a non-null return type.
257-
}, skip: 'https://github.com/dart-lang/webdev/issues/1818');
258+
});
258259

259260
test('can refresh the page via the fullReload service extension', () async {
260261
final client = context.debugConnection.vmService;

0 commit comments

Comments
 (0)