Update

dart-lang · Nov 13, 2023 · 0fe4b74 · 0fe4b74
1 parent 3eda91e
commit 0fe4b74
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 5 deletions.
diff --git a/frontend_server_client/CHANGELOG.md b/frontend_server_client/CHANGELOG.md
@@ -1,4 +1,11 @@
-## 3.3.0-wip
+## 4.0.0-wip
+
+- By default, start the frontend server from the AOT snapshot shipped in the
+  Dart SDK.
+- Throw an `ArgumentError` when `FrontendServerClient.start` is called with the
+  `frontendServerPath` argument omitted and the `debug` argument set to true.
+
+## 3.3.0
 
 - Update Dart SDK constraint to `>=3.0.0 <4.0.0`.
 - Support changes in the SDK layout for Dart 3.0.

diff --git a/frontend_server_client/lib/src/frontend_server_client.dart b/frontend_server_client/lib/src/frontend_server_client.dart
@@ -47,8 +47,8 @@ class FrontendServerClient {
   ///
   /// When the [frontendServerPath] argument is provided, setting [debug] to
   /// true permits debuggers to attach to the frontend server. When the
-  /// [frontendServerPath] argument is omitted, the value of the [debug]
-  /// argument is ignored.
+  /// [frontendServerPath] argument is omitted, setting [debug] to true will
+  /// cause an [ArgumentError] to be thrown.
   static Future<FrontendServerClient> start(
     String entrypoint,
     String outputDillPath,
@@ -109,6 +109,10 @@ class FrontendServerClient {
             commonArguments,
       );
     } else if (File(_feServerAotSnapshotPath).existsSync()) {
+      if (debug) {
+        throw ArgumentError('The debug argument cannot be set to true when the '
+            'frontendServerPath argument is omitted.');
+      }
       feServer = await Process.start(
         _dartAotRuntimePath,
         <String>[_feServerAotSnapshotPath] + commonArguments,

diff --git a/frontend_server_client/pubspec.yaml b/frontend_server_client/pubspec.yaml
@@ -1,5 +1,5 @@
 name: frontend_server_client
-version: 3.3.0-wip
+version: 4.0.0-wip
 description: >-
   Client code to start and interact with the frontend_server compiler from the
   Dart SDK.

diff --git a/frontend_server_common/CHANGELOG.md b/frontend_server_common/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.2.2
+
+- Start the frontend server from the AOT snapshot shipped in the Dart SDK.
+
 ## 0.2.1
 
 - Doe not pass `-debugger-module-names` flag to the frontend server.

diff --git a/test_common/lib/test_sdk_layout.dart b/test_common/lib/test_sdk_layout.dart
@@ -94,7 +94,7 @@ class TestSdkLayout {
           sdkLayout.sdkDirectory,
           'bin',
           'snapshots',
-          'frontend_server.dart.snapshot',
+          'frontend_server_aot.dart.snapshot',
         ),
         dartdevcSnapshotPath: sdkLayout.dartdevcSnapshotPath,
         kernelWorkerSnapshotPath: p.join(