Use a bit more robust _isSdkDir test?

[kevmoo]

The existence of bin/dart would be an equally cheap test, I think.

[sethladd]

Would this work even with symlinks?

[kevmoo]

You can always resolve symlinks when looking for a file.

[sethladd]

Is there a care where the current logic fails?

Or s/robust/simple ?

I'll let @pq take it from here.

[pq]

Certainly I think we need some more developed tests. This code is storied and actually the result of lots of iteration so actually pretty hardened. We have @devoncarew to thank for that!

@sethladd : are you worried about anything in particular besides symlinks? False positives? False negatives?

Needless to say, test cases are welcome!

[pq]

@sethladd: back to the failure case, indeed their was. :) Patched here: dart-archive/cli_util#4

[sethladd]

All props go to @kevmoo

[pq]

As we're now usingPlatform.environment['DART_SDK'] I think we're pretty good.