Add isSorted and related matchers #2490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting one of the admins to take a look at this PR. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
AgamAgarwal
force-pushed
the
is_sorted
branch
2 times, most recently
from
5f77ab9 to
e43a1d2
Compare
|
Updated the code to fix the failures which came up in |
lrhn
reviewed
May 7, 2025
This ensures that a single iteration happens. This is also how iterable_extensions.dart implements the corresponding methods. Also, rename the parameter from `comparator` to `compare` to match those functions.
…g method to `isSortedUsing`
lrhn
reviewed
May 12, 2025
This will give more information about where the actual mismatch happened.
Handle errors from keyOf and compare functions and construct the mismatch description accordingly.
|
@dart-lang/core-package-admins We need someone with actual test-package experience to review this too. |
natebosch
approved these changes
Jun 4, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 5, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/6a71aeb..1d9d60c): 1d9d60c 2025-06-05 Jacob MacDonald handle relative paths under roots without trailing slashes (dart-lang/ai#152) ecosystem (https://github.com/dart-lang/ecosystem/compare/8cebaf0..64aac3a): 64aac3a 2025-06-03 Daco Harkes [health] Bump dart_apitool (dart-lang/ecosystem#360) i18n (https://github.com/dart-lang/i18n/compare/e44af54..43214dd): 43214dde 2025-06-04 Moritz Upgrade to new native_assets (dart-lang/i18n#964) protobuf (https://github.com/dart-lang/protobuf/compare/c69077d..32d53da): 32d53da 2025-06-05 Devon Carew Refactor the test goldens so they have standard file name extensions (google/protobuf.dart#1014) test (https://github.com/dart-lang/test/compare/e2ddae9..0793a2b): 0793a2b3 2025-06-05 Agam Agarwal Add isSorted and related matchers (dart-lang/test#2490) tools (https://github.com/dart-lang/tools/compare/04c6849..e84cbd9): e84cbd9e 2025-06-04 Christophe Coevoet [source_span] Add a test covering the highlighting of non-contiguous spans (dart-lang/tools#1666) 700a3c4d 2025-06-04 Liam Appelbe [coverage] Fix remaining ~0.1% flakiness (dart-lang/tools#2102) webdev (https://github.com/dart-lang/webdev/compare/64492b2..55941b0): 55941b0c 2025-06-05 Kevin Moore [dwds] DRY up MD5/etag logic (dart-lang/webdev#2625) ab7c4d68 2025-06-05 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/webdev#2593) f149e43f 2025-06-05 Nate Biggs Update e2e_test expectation to look for more consistent message. (dart-lang/webdev#2630) 80b1686b 2025-06-03 Nicholas Shahan Fix e2e_test to work with current DDC output (dart-lang/webdev#2626) Change-Id: I4802d7c4a7e39ba238f2f4ce0748dfa6dba9d8c4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433240 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sorting related matchers for iterables.
These match the functions available in https://github.com/dart-lang/core/blob/main/pkgs/collection/lib/src/iterable_extensions.dart