Skip to content

Commit a833663

Browse files
authored
[test] ignore deprecated pkg:js (for now) (#2458)
1 parent 17609bf commit a833663

File tree

5 files changed

+22
-17
lines changed

5 files changed

+22
-17
lines changed

pkgs/test/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
## 1.25.16-wip
2+
13
## 1.25.15
24

35
* Allow the latest version of `package:shelf_web_socket`.

pkgs/test/lib/src/runner/browser/dom.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
// ignore: deprecated_member_use
66
import 'dart:js_util' as js_util;
77

8+
// ignore: deprecated_member_use
89
import 'package:js/js.dart';
910

1011
@JS()

pkgs/test/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: test
2-
version: 1.25.15
2+
version: 1.25.16-wip
33
description: >-
44
A full featured library for writing and running Dart tests across platforms.
55
repository: https://github.com/dart-lang/test/tree/master/pkgs/test

pkgs/test/test/runner/node/runner_test.dart

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -290,17 +290,17 @@ void main() {
290290
test('forwards raw JS prints from the Node test', () async {
291291
await d.file('test.dart', '''
292292
import 'dart:async';
293-
294-
import 'package:js/js.dart';
293+
import 'dart:js_interop';
294+
295295
import 'package:test/test.dart';
296-
297-
@JS("console.log")
298-
external void log(value);
299-
296+
297+
@JS('console.log')
298+
external void log(JSString value);
299+
300300
void main() {
301-
test("test", () {
302-
log("Hello,");
303-
return Future(() => log("world!"));
301+
test('test', () {
302+
log('Hello,'.toJS);
303+
return Future(() => log('world!'.toJS));
304304
});
305305
}
306306
''').create();
@@ -339,20 +339,21 @@ void main() {
339339
]).create();
340340

341341
await d.file('test.dart', '''
342-
import 'package:js/js.dart';
342+
import 'dart:js_interop';
343+
343344
import 'package:test/test.dart';
344-
345+
345346
@JS()
346347
external MyModule require(String name);
347-
348+
348349
@JS()
349-
class MyModule {
350+
extension type MyModule(JSObject _) implements JSObject {
350351
external int get value;
351352
}
352-
353+
353354
void main() {
354-
test("can load from a module", () {
355-
expect(require("my_module").value, equals(12));
355+
test('can load from a module', () {
356+
expect(require('my_module').value, equals(12));
356357
});
357358
}
358359
''').create();

pkgs/test/tool/host.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ library;
88
import 'dart:async';
99
import 'dart:convert';
1010

11+
// ignore: deprecated_member_use
1112
import 'package:js/js.dart';
1213
import 'package:stack_trace/stack_trace.dart';
1314
import 'package:stream_channel/stream_channel.dart';

0 commit comments

Comments
 (0)