Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange collections page #4755

Merged
merged 7 commits into from
Apr 18, 2023
Merged

Rearrange collections page #4755

merged 7 commits into from
Apr 18, 2023

Conversation

MaryaBelanger
Copy link
Contributor

The collections page was oddly organized.

For some reason, spread and collection operators were under the list section, even though they're applicable to all collections. So I moved them out to their own section.

Also, each collection section had the same few "learn more" lines at the bottom, all linking to the same resources, again applicable to all. So I consolidated all of that at the top.

@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Visit the preview URL for this PR (updated for commit 95e9e2b):

https://dart-dev--pr4755-collection-operators-977ilr6o.web.app

(expires Mon, 24 Apr 2023 21:48:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this. This new structure makes a lot more sense!

I have a few small comments, let me know what you think :)

src/_data/side-nav.yml Show resolved Hide resolved
src/language/collections.md Outdated Show resolved Hide resolved
src/language/collections.md Outdated Show resolved Hide resolved
src/language/collections.md Outdated Show resolved Hide resolved
src/language/collections.md Outdated Show resolved Hide resolved
@parlough parlough added the review.await-update Awaiting Updates after Edits label Apr 12, 2023
@MaryaBelanger MaryaBelanger self-assigned this Apr 13, 2023
@parlough parlough removed the review.await-update Awaiting Updates after Edits label Apr 17, 2023
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of those adjustments, looks good to me!

Just as a note, I pushed a change updating all old links to point to the new header.

@parlough parlough added the st.RFM Ready to merge or land label Apr 17, 2023
@MaryaBelanger MaryaBelanger merged commit a417284 into main Apr 18, 2023
@MaryaBelanger MaryaBelanger deleted the collection-operators branch April 18, 2023 16:14
rmacnak-google pushed a commit to rmacnak-google/site-www that referenced this pull request Sep 5, 2023
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
st.RFM Ready to merge or land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants