Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from using Map constructor in 'Generics' examples #5036

Open
parlough opened this issue Jul 3, 2023 · 0 comments
Open

Move away from using Map constructor in 'Generics' examples #5036

parlough opened this issue Jul 3, 2023 · 0 comments
Labels
a.language Relates to the Dart language tour d.enhancement Improves docs with specific ask e1-hours Can complete in < 8 hours of normal, not dedicated, work from.team Reported by Dash docs team member from.to-do Issue raised from inline TODO comment p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@parlough
Copy link
Member

parlough commented Jul 3, 2023

Page URL

https://dart.dev/language/generics.html

Page source

https://github.com/dart-lang/site-www/tree/main/src/language/generics.md

Describe the problem

In Using parameterized types with constructors on https://github.com/dart-lang/site-www/blob/main/src/language/generics.md?plain=1#L122 we have an example that uses the normal constructor for an empty Map. This is not idiomatic Dart, since cases like that should use map literals.

Expected fix

Adjust the example to use a different class besides Map.

Additional context

No response
@parlough parlough added d.enhancement Improves docs with specific ask a.language Relates to the Dart language tour p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Can complete in < 8 hours of normal, not dedicated, work labels Jul 3, 2023
@parlough parlough mentioned this issue Jul 3, 2023
Merged
parlough added a commit that referenced this issue Jul 12, 2023
@parlough
Remove old language tour TODOs now tracked elsewhere (#5038)
5dbb91e 
Closes #2950

These issues are now tracked elsewhere, including:

- #5036
- #5037
- #2093
- #4350
@atsansone atsansone added st.triage.ltw Indicates Lead Tech Writer has triaged from.to-do Issue raised from inline TODO comment labels Jul 14, 2023
@atsansone atsansone added the from.team Reported by Dash docs team member label Aug 8, 2023
rmacnak-google pushed a commit to rmacnak-google/site-www that referenced this issue Sep 5, 2023
@parlough @rmacnak-google
Remove old language tour TODOs now tracked elsewhere (dart-lang#5038)
e435c5b 
Closes dart-lang#2950

These issues are now tracked elsewhere, including:

- dart-lang#5036
- dart-lang#5037
- dart-lang#2093
- dart-lang#4350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a.language Relates to the Dart language tour d.enhancement Improves docs with specific ask e1-hours Can complete in < 8 hours of normal, not dedicated, work from.team Reported by Dash docs team member from.to-do Issue raised from inline TODO comment p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atsansone @parlough