Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO(chalin): use $site-color-codeblock-bg #2852

Closed
15 tasks
woinbo opened this issue Jan 13, 2021 · 3 comments
Closed
15 tasks

TODO(chalin): use $site-color-codeblock-bg #2852

woinbo opened this issue Jan 13, 2021 · 3 comments

Comments

@woinbo
Copy link
Contributor

woinbo commented Jan 13, 2021

we need to refactor these TODO's if someone interested does comment on this issue.

Find pages with TODO's, and refactor them by changing code or add new code to that file.

Here's a list of the 11 pages we should look at and eventually update (there might be more that don't show up due to improper formatting):

  • Style Related
  • Dart analyze
  • TODO @johnpryan: After dart CLI ships in stable, use dart analyze for all channels. link to file

  • TODO(chalin): as of 2019/11/17, we don't need to select individual browser test files. Run browser tests over all files, since VM-only tests have been annotated as such.
    link to file

  • Regexp
  • TODO: maybe style special characters inside a regexp as punctuation. link to file
  • Version related:
  • TODO: identify versions (on line number 767)

  • TODO: identify versions (on line number 781) link to file

  • TODO: Next time we update this page, remove the toc line above. link to file

  • Fix build instructions

@kwalrath will assign the task's

@kwalrath
Copy link
Contributor

Actually... What I meant was to file one issue per group of TODOs. So one issue for the style TODOs, one for the dart analyze TODOs, etc. Then create one or more PRs to point from each TODO to the relevant issue.

@woinbo
Copy link
Contributor Author

woinbo commented Jan 14, 2021

Sorry, @kwalrath I took it wrong but I have fixed the mistake with these relevant issues #2859 #2860 #2861 #2862 #2863. I have one question what about the issues which don't lay in any category. Should I create one single issue for those?

@kwalrath
Copy link
Contributor

Sorry, @kwalrath I took it wrong but I have fixed the mistake with these relevant issues #2859 #2860 #2861 #2862 #2863.

Thank you!

I have one question what about the issues which don't lay in any category. Should I create one single issue for those?

One issue per category-less TODO, please. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants