Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need guidance on migrating package examples #2776

Open
timsneath opened this issue Nov 19, 2020 · 4 comments
Open

Need guidance on migrating package examples #2776

timsneath opened this issue Nov 19, 2020 · 4 comments
Labels
dev.null-safety Relates to transforming or migrating Dart code to sound null safety dev.packages Relates to package publishing e2-days Can complete in < 5 days of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@timsneath
Copy link
Contributor

One note from my last-mile experience: there's no mention in the docs about migrating examples / samples, yet they're quite likely to have a separate pubspec.yaml.

That introduces a number of (unanswered) questions. For example, what if an example doesn't have all its dependencies migrated? Is it better to not start the migration? Start the migration but leave the example unmigrated? Migrate the example and just ignore the complaints about its dependencies?

/cc @kevmoo

@kwalrath kwalrath added act.wait-for-customer Needs response from customer dev.null-safety Relates to transforming or migrating Dart code to sound null safety labels Nov 19, 2020
@kevmoo
Copy link
Member

kevmoo commented Nov 20, 2020

We absolutely want to make sure the example still runs.

The only way to do that (without requiring a user to pass flags) is to have the example flagged with // @dart=2.9

Either way, we should tell folks to migrate their examples, but if they cannot be run strongly, the example should have some screaming comments at the top telling folks such

@atsansone
Copy link
Contributor

@kevmoo : Is this still an active concern?

@kevmoo
Copy link
Member

kevmoo commented Apr 11, 2023

CC @mit-mit who looks after the package ecosystem. I'm guessing when analysis rolls over to Dart 3.0, existing examples will break. Not sure about guidance, though.

@mit-mit
Copy link
Member

mit-mit commented Apr 12, 2023

Yes, this is still a valid concern for any package that needs to be migrated to either 2.12 or 3.0

@atsansone atsansone added e2-days Can complete in < 5 days of normal, not dedicated, work st.triage.ltw Indicates Lead Tech Writer has triaged dev.packages Relates to package publishing and removed act.wait-for-customer Needs response from customer labels Apr 12, 2023
@parlough parlough added the p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev.null-safety Relates to transforming or migrating Dart code to sound null safety dev.packages Relates to package publishing e2-days Can complete in < 5 days of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Development

No branches or pull requests

6 participants