Skip to content

Commit

Permalink
fix: Use .zip in archive path (#119)
Browse files Browse the repository at this point in the history
* fix: Use `.zip` in archive path

Fixes #118

Ensures that downloads of the Dart SDK zip file carry the `.zip` extension so that subsequent calls to `Expand-Archive` on Windows succeed.

## Notes

- The diff of `index.mjs` is quite large. I believe this is due to the version of Node I'm using (`20.7.0`). Happy to use a different version to keep the diff small, but wasn't sure which one is currently used. This could be noted in `package.json` to ensure alignment with external contributions.

* Update link

* Update changelog

* Reformat and sign w/ Dart 3.4.1
  • Loading branch information
dnys1 authored Jun 24, 2024
1 parent 2986c8e commit 4e61f04
Show file tree
Hide file tree
Showing 11 changed files with 608 additions and 545 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## v1.6.5-wip

- Fix zip path handling on Windows 11 ([#118][])

[#118]: https://github.com/dart-lang/setup-dart/issues/118

## v1.6.4

* Rebuild JS code.
Expand Down
Loading

0 comments on commit 4e61f04

Please sign in to comment.