Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart editor incremental parser doesn't handle string interpolation properly #7768

Closed
DartBot opened this issue Jan 8, 2013 · 12 comments
Closed
Assignees
Labels
analyzer-recovery area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jan 8, 2013

This issue was originally filed by podivilov@google.com


When inserting a "${0} at the beginning of a huge file, editor adds a error markers to all lines in the file and scrolling and editing become very slow.

Strings without interpolation (e.g. "foo) are handled correctly.

@bwilkerson
Copy link
Member

Added this to the M3 milestone.
Removed Area-Editor label.
Added Area-Analyzer label.

@scheglov
Copy link
Contributor

Works for me.
I have file with 13000 lines, only one line with error.


Attachment:
[Screen Shot 2013-01-22 at 6.33.40 PM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-7768/comment-2/Screen Shot 2013-01-22 at 6.33.40 PM.png) (120.37 KB)


Set owner to @scheglov.
Added CannotReproduce label.

@DartBot
Copy link
Author

DartBot commented Jan 23, 2013

This comment was originally written by podivilov@google.com


  1. Create an app with the following code:
    void main() {
      var x = "${0
      print('1');
      print('2');
      print('3');
    }
  2. All the lines below "${0} have an error marker, see attached screenshot.

Dart Editor version is 0.1.2_r17412, on linux.


Attachment:
[Screenshot from 2013-01-23 12:58:06.png](https://storage.googleapis.com/google-code-attachments/dart/issue-7768/comment-3/Screenshot from 2013-01-23 12:58:06.png) (37.05 KB)


Added Triaged label.

@scheglov
Copy link
Contributor

Removed the owner.
Removed this from the M3 milestone.
Added this to the Later milestone.
Added AnalysisEngine label.

@DartBot
Copy link
Author

DartBot commented Apr 7, 2013

This comment was originally written by amouravski@google.com


Added Editor-AnalysisEngine label.

@bwilkerson
Copy link
Member

Set owner to @bwilkerson.
Removed Type-Defect, AnalysisEngine, Editor-AnalysisEngine labels.
Added Type-Enhancement label.

@bwilkerson
Copy link
Member

Added Analyzer-Recovery label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@DartBot DartBot added Type-Enhancement area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-recovery labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Feb 29, 2016
@srawlins
Copy link
Member

Dart Editor is dead. And this seems like it is maybe a dup of #946 as its filed just under "analyzer-recovery" now. Close?

@bwilkerson
Copy link
Member

Most issues reported against Dart Editor were really issues with the analyzer.

It's a slightly different case from a recovery perspective because the string is not terminated.

@bwilkerson
Copy link
Member

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-recovery area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants