Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] DevTools 2.40.3 #59884

Open
elliette opened this issue Jan 10, 2025 · 1 comment
Open

[CP] DevTools 2.40.3 #59884

elliette opened this issue Jan 10, 2025 · 1 comment
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). cherry-pick-review Issue that need cherry pick triage to approve triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.

Comments

@elliette
Copy link
Contributor

elliette commented Jan 10, 2025 •
edited
Loading

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/404061

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/404061

Issue Description

The DevTools analytics is missing data in its analytics to distinguish whether events are coming from the new or legacy inspector. This is because the parameter that was added is a boolean, but Google Analytics 4 only supports string or int values.

Why cherry-pick

Without being able to distinguish between the new and legacy inspector events, we are unable to monitor the rollout of the new inspector and mitigate any issues that arise.

Risk

Low

Issue link(s)

flutter/devtools#8690
@elliette elliette added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 10, 2025
@dart-github-bot
Copy link
Collaborator

Summary: DevTools 2.40.3 cherry-pick to stable. Issue details and justification pending.

@dart-github-bot dart-github-bot added area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). cherry-pick-review Issue that need cherry pick triage to approve triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vsmenon @itsjustkevin @mit-mit @athomas @elliette @dart-github-bot