Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on pkg/analysis_server/test/integration/edit/get_refactoring_test #59706

Open
jyameo opened this issue Dec 12, 2024 · 3 comments
Open

Failures on pkg/analysis_server/test/integration/edit/get_refactoring_test #59706

jyameo opened this issue Dec 12, 2024 · 3 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. gardening P2 A bug or feature request we're likely to work on triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jyameo
Copy link
Contributor

jyameo commented Dec 12, 2024

There are new test failures on Migrate 5 more rename pieces and a utility class.

The tests

pkg/analysis_server/test/integration/edit/get_refactoring_test RuntimeError (expected Pass)

are failing on configurations

analyzer-unittest-asserts-release-mac
analyzer-unittest-asserts-release-win

LOGS:
https://dart-ci.appspot.com/log/analyzer-mac-release/analyzer-unittest-asserts-release-mac/29959/pkg/analysis_server/test/integration/edit/get_refactoring_test
https://dart-ci.appspot.com/log/analyzer-win-release/analyzer-unittest-asserts-release-win/29467/pkg/analysis_server/test/integration/edit/get_refactoring_test
@dart-github-bot
Copy link
Collaborator

Summary: Integration tests in get_refactoring_test fail on macOS and Windows after a rename refactoring change. Runtime errors prevent test suite completion.

@dart-github-bot dart-github-bot added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Dec 12, 2024
@bwilkerson
Copy link
Member

This appears to have been fixed by https://dart.googlesource.com/sdk/+/61ba8df51045a535643b6c5315663595bee91529.

@jyameo jyameo reopened this Dec 18, 2024
@jyameo
Copy link
Contributor Author

jyameo commented Dec 18, 2024 •
edited
Loading

Looks like this test is still flaky. However this time still failing on a different configurations:

There are new test failures on Bump tools to febccb92d228e678196aa90c109c708ed7ad6ea8...[analysis_server] Move Type Hierarchy off ElementLocation to its own internal uri/name encoding.

The tests

pkg/analysis_server/test/integration/edit/get_refactoring_test RuntimeError (expected Pass)

are failing on configurations

analyzer-unittest-asserts-release-linux

LOGS: https://dart-ci.appspot.com/log/analyzer-linux-release/analyzer-unittest-asserts-release-linux/27832/pkg/analysis_server/test/integration/edit/get_refactoring_test

@keertip keertip added the P2 A bug or feature request we're likely to work on label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. gardening P2 A bug or feature request we're likely to work on triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@keertip @jyameo @bwilkerson @dart-github-bot